public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: "周琰杰 (Zhou Yanjie)" <zhouyanjie@wanyeetech.com>,
	balbi@kernel.org, gregkh@linuxfoundation.org, kishon@ti.com,
	vkoul@kernel.org, paul@crapouillou.net
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org, dongsheng.qiu@ingenic.com,
	aric.pzqi@ingenic.com, rick.tyliu@ingenic.com
Subject: [PATCH] USB: PHY: JZ4770: fix ptr_ret.cocci warnings
Date: Wed, 16 Sep 2020 14:55:01 +0800	[thread overview]
Message-ID: <20200916065501.GA29980@fc326f28f0ae> (raw)
In-Reply-To: <20200913063430.9622-3-zhouyanjie@wanyeetech.com>

From: kernel test robot <lkp@intel.com>

drivers/phy/ingenic/phy-ingenic-usb.c:348:1-3: WARNING: PTR_ERR_OR_ZERO can be used


 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

CC: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

url:    https://github.com/0day-ci/linux/commits/Zhou-Yanjie/Use-the-generic-PHY-framework-for-Ingenic-USB-PHY/20200913-143611
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next

 phy-ingenic-usb.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

--- a/drivers/phy/ingenic/phy-ingenic-usb.c
+++ b/drivers/phy/ingenic/phy-ingenic-usb.c
@@ -345,10 +345,7 @@ static int ingenic_usb_phy_probe(struct
 	phy_set_drvdata(priv->phy, priv);
 
 	provider = devm_of_phy_provider_register(priv->dev, of_phy_simple_xlate);
-	if (IS_ERR(provider))
-		return PTR_ERR(provider);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(provider);
 }
 
 static const struct of_device_id ingenic_usb_phy_of_matches[] = {

      parent reply	other threads:[~2020-09-16  6:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-13  6:34 [PATCH v3 0/2] Use the generic PHY framework for Ingenic USB PHY 周琰杰 (Zhou Yanjie)
2020-09-13  6:34 ` [PATCH v3 1/2] USB: PHY: JZ4770: Remove unnecessary function calls 周琰杰 (Zhou Yanjie)
2020-09-13  6:34 ` [PATCH v3 2/2] USB: PHY: JZ4770: Use the generic PHY framework 周琰杰 (Zhou Yanjie)
2020-09-15 22:47   ` Paul Cercueil
2020-09-16 16:27     ` Zhou Yanjie
2020-09-16  6:55   ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200916065501.GA29980@fc326f28f0ae \
    --to=lkp@intel.com \
    --cc=aric.pzqi@ingenic.com \
    --cc=balbi@kernel.org \
    --cc=dongsheng.qiu@ingenic.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kbuild-all@lists.01.org \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=paul@crapouillou.net \
    --cc=rick.tyliu@ingenic.com \
    --cc=vkoul@kernel.org \
    --cc=zhouyanjie@wanyeetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox