From: Jiri Olsa <jolsa@redhat.com>
To: Ian Rogers <irogers@google.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Michael Petlan <mpetlan@redhat.com>,
Song Liu <songliubraving@fb.com>,
"Frank Ch. Eigler" <fche@redhat.com>,
Stephane Eranian <eranian@google.com>,
Alexey Budankov <alexey.budankov@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>,
Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH 16/26] perf tools: Synthesize modules with mmap3
Date: Wed, 16 Sep 2020 10:20:18 +0200 [thread overview]
Message-ID: <20200916082018.GA2301783@krava> (raw)
In-Reply-To: <CAP-5=fV4Agxe3UMpkbWkh9CuG1tYho413w7xehy0SiMX+tPv1Q@mail.gmail.com>
On Tue, Sep 15, 2020 at 01:17:44PM -0700, Ian Rogers wrote:
SNIP
> > > /*
> > > * kernel uses 0 for user space maps, see kernel/perf_event.c
> > > * __perf_event_mmap
> > > @@ -631,17 +629,30 @@ int perf_event__synthesize_modules(struct perf_tool *tool, perf_event__handler_t
> > > continue;
> > >
> > > size = PERF_ALIGN(pos->dso->long_name_len + 1, sizeof(u64));
> > > - event->mmap.header.type = PERF_RECORD_MMAP;
> > > - event->mmap.header.size = (sizeof(event->mmap) -
> > > - (sizeof(event->mmap.filename) - size));
> > > - memset(event->mmap.filename + size, 0, machine->id_hdr_size);
> > > - event->mmap.header.size += machine->id_hdr_size;
> > > - event->mmap.start = pos->start;
> > > - event->mmap.len = pos->end - pos->start;
> > > - event->mmap.pid = machine->pid;
> > > -
> > > - memcpy(event->mmap.filename, pos->dso->long_name,
> > > + event->mmap3.header.type = PERF_RECORD_MMAP3;
> > > + event->mmap3.header.size = (sizeof(event->mmap3) -
> > > + (sizeof(event->mmap3.filename) - size));
> > > + memset(event->mmap3.filename + size, 0, machine->id_hdr_size);
> > > + event->mmap3.header.size += machine->id_hdr_size;
> > > + event->mmap3.start = pos->start;
> > > + event->mmap3.len = pos->end - pos->start;
> > > + event->mmap3.pid = machine->pid;
> > > +
> > > + memcpy(event->mmap3.filename, pos->dso->long_name,
> > > pos->dso->long_name_len + 1);
> > > +
> > > + rc = filename__read_build_id(event->mmap3.filename, event->mmap3.buildid,
> > > + BUILD_ID_SIZE);
> > > + if (rc != BUILD_ID_SIZE) {
>
> IIRC BUILD_ID_SIZE is 20 bytes which is the correct size for SHA-1. A
> build ID may be 128-bits (16 bytes) if md5 or uuid hashes are used.
> Should this test just be "> 0" ?
ah right, will check on that
thanks,
jirka
next prev parent reply other threads:[~2020-09-16 8:20 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-13 21:02 [RFC 00/26] perf: Add mmap3 support Jiri Olsa
2020-09-13 21:02 ` [PATCH 01/26] bpf: Move stack_map_get_build_id into lib Jiri Olsa
2020-09-14 6:09 ` Song Liu
2020-09-13 21:02 ` [PATCH 02/26] perf: Introduce mmap3 version of mmap event Jiri Olsa
2020-09-14 5:38 ` Namhyung Kim
2020-09-14 6:20 ` Song Liu
2020-09-14 19:38 ` Jiri Olsa
2020-09-14 15:28 ` Arnaldo Carvalho de Melo
2020-09-14 16:35 ` peterz
2020-09-14 17:08 ` Ian Rogers
2020-09-14 20:07 ` Jiri Olsa
2020-09-15 5:49 ` Adrian Hunter
2020-09-14 19:38 ` Jiri Olsa
2020-09-14 19:39 ` Jiri Olsa
2020-09-14 22:00 ` Arnaldo Carvalho de Melo
2020-09-15 5:39 ` Adrian Hunter
2020-09-14 19:38 ` Jiri Olsa
2020-09-15 2:54 ` Namhyung Kim
2020-09-14 6:41 ` Stephane Eranian
2020-09-14 9:08 ` peterz
2020-09-14 15:32 ` Arnaldo Carvalho de Melo
2020-09-14 17:26 ` Stephane Eranian
2020-09-14 19:56 ` Jiri Olsa
2020-09-15 0:03 ` Ian Rogers
2020-09-14 15:31 ` Arnaldo Carvalho de Melo
2020-09-14 19:50 ` Jiri Olsa
2020-09-14 22:38 ` Arnaldo Carvalho de Melo
2020-09-14 19:45 ` Jiri Olsa
2020-09-14 9:36 ` peterz
2020-09-13 21:02 ` [PATCH 03/26] tools headers uapi: Sync tools/include/uapi/linux/perf_event.h Jiri Olsa
2020-09-14 5:39 ` Namhyung Kim
2020-09-13 21:02 ` [PATCH 04/26] perf tools: Add filename__decompress function Jiri Olsa
2020-09-14 15:35 ` Arnaldo Carvalho de Melo
2020-09-14 20:43 ` Jiri Olsa
2020-09-17 18:54 ` Arnaldo Carvalho de Melo
2020-09-18 10:51 ` Jiri Olsa
2020-09-13 21:02 ` [PATCH 05/26] perf tools: Add build_id__is_defined function Jiri Olsa
2020-09-14 5:44 ` Namhyung Kim
2020-09-14 16:03 ` Arnaldo Carvalho de Melo
2020-09-14 20:49 ` Jiri Olsa
2020-09-14 20:47 ` Jiri Olsa
2020-09-14 21:51 ` Arnaldo Carvalho de Melo
2020-09-13 21:02 ` [PATCH 06/26] perf tools: Add support to read build id from compressed elf Jiri Olsa
2020-09-14 16:04 ` Arnaldo Carvalho de Melo
2020-09-14 20:49 ` Jiri Olsa
2020-09-13 21:02 ` [PATCH 07/26] perf tools: Add check for existing link in buildid dir Jiri Olsa
2020-09-14 5:54 ` Namhyung Kim
2020-09-14 20:18 ` Jiri Olsa
2020-09-13 21:02 ` [PATCH 08/26] perf tools: Use struct extra_kernel_map in machine__process_kernel_mmap_event Jiri Olsa
2020-09-13 21:02 ` [PATCH 09/26] perf tools: Try load vmlinux from buildid database Jiri Olsa
2020-09-14 6:25 ` Namhyung Kim
2020-09-14 20:29 ` Jiri Olsa
2020-09-15 2:58 ` Namhyung Kim
2020-09-13 21:02 ` [PATCH 10/26] perf tools: Enable mmap3 map event when supported Jiri Olsa
2020-09-14 16:05 ` Arnaldo Carvalho de Melo
2020-09-13 21:02 ` [PATCH 11/26] perf tools: Add mmap3 support Jiri Olsa
2020-09-13 21:02 ` [PATCH 12/26] perf tools: Set build id for kernel dso objects Jiri Olsa
2020-09-13 21:03 ` [PATCH 13/26] perf tools: Plug in mmap3 event Jiri Olsa
2020-09-13 21:03 ` [PATCH 14/26] perf tools: Add mmap3 events to --show-mmap-events option Jiri Olsa
2020-09-14 6:30 ` Namhyung Kim
2020-09-14 20:29 ` Jiri Olsa
2020-09-13 21:03 ` [PATCH 15/26] perf tools: Synthesize proc tasks with mmap3 Jiri Olsa
2020-09-14 16:07 ` Arnaldo Carvalho de Melo
2020-09-14 20:51 ` Jiri Olsa
2020-09-13 21:03 ` [PATCH 16/26] perf tools: Synthesize modules " Jiri Olsa
2020-09-14 16:07 ` Arnaldo Carvalho de Melo
2020-09-15 20:17 ` Ian Rogers
2020-09-16 8:20 ` Jiri Olsa [this message]
2020-09-16 14:07 ` Arnaldo Carvalho de Melo
2020-09-16 14:17 ` peterz
2020-09-16 15:10 ` Arnaldo Carvalho de Melo
2020-09-16 15:20 ` peterz
2020-09-16 15:21 ` Jiri Olsa
2020-09-16 15:42 ` Arnaldo Carvalho de Melo
2020-09-13 21:03 ` [PATCH 17/26] perf tools: Synthesize kernel " Jiri Olsa
2020-09-14 16:08 ` Arnaldo Carvalho de Melo
2020-09-13 21:03 ` [PATCH 18/26] perf tests: Add mmap3 support for perf record test Jiri Olsa
2020-09-13 21:03 ` [PATCH 19/26] perf tools: Add buildid-list support for mmap3 Jiri Olsa
2020-09-13 21:03 ` [PATCH 20/26] perf tools: Add build_id_cache__add function Jiri Olsa
2020-09-14 16:13 ` Arnaldo Carvalho de Melo
2020-09-13 21:03 ` [PATCH 21/26] perf tools: Add machine__for_each_dso function Jiri Olsa
2020-09-14 16:15 ` Arnaldo Carvalho de Melo
2020-09-13 21:03 ` [PATCH 22/26] perf tools: Use machine__for_each_dso in perf_session__cache_build_ids Jiri Olsa
2020-09-13 21:03 ` [PATCH 23/26] perf tools: Add __perf_session__cache_build_ids function Jiri Olsa
2020-09-13 21:03 ` [PATCH 24/26] perf tools: Add buildid-list --store option Jiri Olsa
2020-09-14 6:42 ` Namhyung Kim
2020-09-14 15:14 ` Arnaldo Carvalho de Melo
2020-09-14 20:42 ` Jiri Olsa
2020-09-14 20:42 ` Jiri Olsa
2020-09-13 21:03 ` [PATCH 25/26] perf tools: Move debuginfo download code into get_debuginfo Jiri Olsa
2020-09-13 21:03 ` [PATCH 26/26] perf tools: Add report --store option Jiri Olsa
2020-09-14 5:25 ` [RFC 00/26] perf: Add mmap3 support Namhyung Kim
2020-09-14 15:13 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916082018.GA2301783@krava \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=eranian@google.com \
--cc=fche@redhat.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox