From: Gao Xiang <hsiangkao@redhat.com>
To: Chao Yu <chao@kernel.org>
Cc: linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Chao Yu <yuchao0@huawei.com>
Subject: Re: [PATCH] erofs: remove unneeded parameter
Date: Wed, 16 Sep 2020 22:36:48 +0800 [thread overview]
Message-ID: <20200916143648.GA23921@xiangao.remote.csb> (raw)
In-Reply-To: <20200916143304.GA23176@xiangao.remote.csb>
On Wed, Sep 16, 2020 at 10:33:04PM +0800, Gao Xiang wrote:
> Hi Chao,
>
> On Wed, Sep 16, 2020 at 10:06:04PM +0800, Chao Yu wrote:
> > From: Chao Yu <yuchao0@huawei.com>
> >
> > In below call path, no page will be cached into @pagepool list
> > or grabbed from @pagepool list:
> > - z_erofs_readpage
> > - z_erofs_do_read_page
> > - preload_compressed_pages
> > - erofs_allocpage
> >
> > Let's get rid of this unneeded parameter.
>
> That would be unneeded after .readahead() is introduced recently
> (so add_to_page_cache_lru() is also moved to mm code), so I agree
> with you on it.
(cont.)
... also it'd be better to add such historical reason to the commit
message... since it was of some use before...
Thanks,
Gao Xiang
next prev parent reply other threads:[~2020-09-16 20:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 14:06 [PATCH] erofs: remove unneeded parameter Chao Yu
2020-09-16 14:33 ` Gao Xiang
2020-09-16 14:36 ` Gao Xiang [this message]
2020-09-17 1:05 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916143648.GA23921@xiangao.remote.csb \
--to=hsiangkao@redhat.com \
--cc=chao@kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox