From: Rob Herring <robh@kernel.org>
To: Jim Quinlan <james.quinlan@broadcom.com>
Cc: linux-pci@vger.kernel.org,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Christoph Hellwig <hch@lst.de>,
Robin Murphy <robin.murphy@arm.com>,
bcm-kernel-feedback-list@broadcom.com,
Jim Quinlan <jquinlan@broadcom.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v12 05/10] PCI: brcmstb: Add bcm7278 PERST# support
Date: Wed, 16 Sep 2020 09:24:38 -0600 [thread overview]
Message-ID: <20200916152438.GA3991893@bogus> (raw)
In-Reply-To: <20200911175232.19016-6-james.quinlan@broadcom.com>
On Fri, Sep 11, 2020 at 01:52:25PM -0400, Jim Quinlan wrote:
> From: Jim Quinlan <jquinlan@broadcom.com>
>
> The PERST# bit was moved to a different register in 7278-type STB chips.
> In addition, the polarity of the bit was also changed; for other chips
> writing a 1 specified assert; for 7278-type chips, writing a 0 specifies
> assert. Of course, PERST# is a PCIe asserted-low signal.
>
> While we are here, also change the bridge_sw_init_set() functions so like
> the perst_set() functions they are chip specific and we no longer rely on
> data wrt chip specific field mask and shift values.
>
> Signed-off-by: Jim Quinlan <jquinlan@broadcom.com>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> drivers/pci/controller/pcie-brcmstb.c | 97 +++++++++++++++++++--------
> 1 file changed, 69 insertions(+), 28 deletions(-)
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2020-09-16 18:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 17:52 [PATCH v12 00/10] PCI: brcmstb: enable PCIe for STB chips Jim Quinlan
2020-09-11 17:52 ` [PATCH v12 01/10] PCI: brcmstb: PCIE_BRCMSTB depends on ARCH_BRCMSTB Jim Quinlan
2020-09-11 17:52 ` [PATCH v12 02/10] dt-bindings: PCI: Add bindings for more Brcmstb chips Jim Quinlan
2020-09-11 17:52 ` [PATCH v12 03/10] PCI: brcmstb: Add bcm7278 register info Jim Quinlan
2020-09-11 17:52 ` [PATCH v12 04/10] PCI: brcmstb: Add suspend and resume pm_ops Jim Quinlan
2020-09-16 15:24 ` Rob Herring
2020-09-11 17:52 ` [PATCH v12 05/10] PCI: brcmstb: Add bcm7278 PERST# support Jim Quinlan
2020-09-16 15:24 ` Rob Herring [this message]
2020-09-11 17:52 ` [PATCH v12 06/10] PCI: brcmstb: Add control of rescal reset Jim Quinlan
2020-09-16 15:26 ` Rob Herring
2020-09-11 17:52 ` [PATCH v12 07/10] PCI: brcmstb: Set additional internal memory DMA viewport sizes Jim Quinlan
2020-09-11 17:52 ` [PATCH v12 08/10] PCI: brcmstb: Accommodate MSI for older chips Jim Quinlan
2020-09-11 17:52 ` [PATCH v12 09/10] PCI: brcmstb: Set bus max burst size by chip type Jim Quinlan
2020-09-11 17:52 ` [PATCH v12 10/10] PCI: brcmstb: Add bcm7211, bcm7216, bcm7445, bcm7278 to match list Jim Quinlan
2020-09-17 12:08 ` [PATCH v12 00/10] PCI: brcmstb: enable PCIe for STB chips Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916152438.GA3991893@bogus \
--to=robh@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=f.fainelli@gmail.com \
--cc=hch@lst.de \
--cc=james.quinlan@broadcom.com \
--cc=jquinlan@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=nsaenzjulienne@suse.de \
--cc=p.zabel@pengutronix.de \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox