Re: [PATCH 4/4] mm: Add PGREUSE counter

Linus Torvalds
2020-08-22T16:15:20Z

On Fri, Aug 21, 2020 at 4:50 PM Peter Xu <peterx@redhat.com> wrote:
>
> This accounts for wp_page_reuse() case, where we reused a page for COW.

If we do this, wouldn't it make more sense to also count the COW case
to see how they match up?

Right now we count faults and major faults. So as a result you can can
calculate minor faults trivially.

But if you count page reuse, you can't calculate any stats on it,
because most of the minor faults will presumably be for new pages
(either zero or cached file mappings).

So the "pgreuse" seems to be a counter without any context to it.

IOW, I get the feeling that either we should do this properly (and
maybe count "dirty faults" and "access" faults, at which point the
reuse case becomes a subcase of the dirty ones) or we shouldn't do it
at all. Creating a counter without any way to sanely compare it to
anything seems a bit pointless.

Linus