Re: [PATCH 1/4] mm: Trial do_wp_page() simplification

Peter Xu
2021-02-02T16:39:08Z

On Tue, Feb 02, 2021 at 04:40:33PM +0200, Gal Pressman wrote:
> Hi Peter & Jason,

Hi, Gal, Jason,

>
> It seems the hugetlb part was overlooked?
> We're testing if the RDMA fork MADV_DONTFORK stuff can be removed on appropriate
> kernels, but our tests still fail due to lacking explicit huge pages support [1].

I didn't think it high priority only because I think most hugetlbfs users
should be using it shared, but maybe I'm wrong.. Then it got lost indeed.

But I definitely agree it should better be there.

>
> Peter, was it left unchanged on purpose?
> Are you planning to submit the hugetlb changes as well?
>
> [1] https://github.com/linux-rdma/rdma-core/pull/883#issuecomment-770398171
>

I'll prepare a fix soon and post it. Thanks,

--
Peter Xu