From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net, paulmck@kernel.org, joel@joelfernandes.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
rcu@vger.kernel.org, josh@joshtriplett.org, peterz@infradead.org,
christian.brauner@ubuntu.com, Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next 0/7] rcu: prevent RCU_LOCKDEP_WARN() from swallowing the condition
Date: Wed, 16 Sep 2020 11:45:21 -0700 [thread overview]
Message-ID: <20200916184528.498184-1-kuba@kernel.org> (raw)
Hi!
So I unfolded the RFC patch into smaller chunks and fixed an issue
in SRCU pointed out by build bot. Build bot has been quiet for
a day but I'm not 100% sure it's scanning my tree, so let's
give these patches some ML exposure.
The motivation here is that we run into a unused variable
warning in networking code because RCU_LOCKDEP_WARN() makes
its argument disappear with !LOCKDEP / !PROVE_RCU. We marked
the variable as __maybe_unused, but that's ugly IMHO.
This set makes the relevant function declarations visible to
the compiler and uses (0 && (condition)) to make the compiler
remove those calls before linker realizes they are never defined.
I'm tentatively marking these for net-next, but if anyone (Paul?)
wants to take them into their tree - even better.
Jakub Kicinski (7):
sched: un-hide lockdep_tasklist_lock_is_held() for !LOCKDEP
rcu: un-hide lockdep maps for !LOCKDEP
net: un-hide lockdep_sock_is_held() for !LOCKDEP
net: sched: remove broken definitions and un-hide for !LOCKDEP
srcu: use a more appropriate lockdep helper
lockdep: provide dummy forward declaration of *_is_held() helpers
rcu: prevent RCU_LOCKDEP_WARN() from swallowing the condition
include/linux/lockdep.h | 6 ++++++
include/linux/rcupdate.h | 11 ++++++-----
include/linux/rcupdate_trace.h | 4 ++--
include/linux/sched/task.h | 2 --
include/net/sch_generic.h | 12 ------------
include/net/sock.h | 2 --
kernel/rcu/srcutree.c | 2 +-
7 files changed, 15 insertions(+), 24 deletions(-)
--
2.26.2
next reply other threads:[~2020-09-16 18:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 18:45 Jakub Kicinski [this message]
2020-09-16 18:45 ` [PATCH net-next 1/7] sched: un-hide lockdep_tasklist_lock_is_held() for !LOCKDEP Jakub Kicinski
2020-09-16 18:45 ` [PATCH net-next 2/7] rcu: un-hide lockdep maps " Jakub Kicinski
2020-09-16 18:45 ` [PATCH net-next 3/7] net: un-hide lockdep_sock_is_held() " Jakub Kicinski
2020-09-16 18:45 ` [PATCH net-next 4/7] net: sched: remove broken definitions and un-hide " Jakub Kicinski
2020-09-16 18:45 ` [PATCH net-next 5/7] srcu: use a more appropriate lockdep helper Jakub Kicinski
2020-09-16 18:45 ` [PATCH net-next 6/7] lockdep: provide dummy forward declaration of *_is_held() helpers Jakub Kicinski
2020-09-17 15:14 ` peterz
2020-09-16 18:45 ` [PATCH net-next 7/7] rcu: prevent RCU_LOCKDEP_WARN() from swallowing the condition Jakub Kicinski
2020-09-16 23:15 ` [PATCH net-next 0/7] " Paul E. McKenney
2020-09-17 0:48 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916184528.498184-1-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=christian.brauner@ubuntu.com \
--cc=davem@davemloft.net \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox