Re: [PATCH 3/9] lib: zstd: Upgrade to latest upstream zstd version 1.4.6

kernel test robot
2020-09-16T08:02:34Z

[-- Attachment #1: Type: text/plain, Size: 5169 bytes --]

Hi Nick,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on kdave/for-next]
[also build test WARNING on f2fs/dev-test linus/master v5.9-rc5 next-20200915]
[cannot apply to cryptodev/master crypto/master squashfs/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Nick-Terrell/Update-to-zstd-1-4-6/20200916-114901
base: https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next
config: h8300-randconfig-r024-20200916 (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=h8300

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

In file included from lib/zstd/compress/zstd_compress_internal.h:21,
from lib/zstd/compress/zstd_compress.c:22:
lib/zstd/compress/../common/zstd_internal.h:193:18: warning: 'ML_bits' defined but not used [-Wunused-const-variable=]
193 | static const U32 ML_bits[MaxML+1] = { 0, 0, 0, 0, 0, 0, 0, 0,
| ^~~~~~~
lib/zstd/compress/../common/zstd_internal.h:180:18: warning: 'LL_bits' defined but not used [-Wunused-const-variable=]
180 | static const U32 LL_bits[MaxLL+1] = { 0, 0, 0, 0, 0, 0, 0, 0,
| ^~~~~~~
In file included from lib/zstd/compress/zstd_compress_internal.h:21,
from lib/zstd/compress/zstd_compress.c:22:
lib/zstd/compress/../common/zstd_internal.h:148:21: warning: 'ZSTD_did_fieldSize' defined but not used [-Wunused-const-variable=]
148 | static const size_t ZSTD_did_fieldSize[4] = { 0, 1, 2, 4 };
| ^~~~~~~~~~~~~~~~~~
lib/zstd/compress/../common/zstd_internal.h:147:21: warning: 'ZSTD_fcs_fieldSize' defined but not used [-Wunused-const-variable=]
147 | static const size_t ZSTD_fcs_fieldSize[4] = { 0, 2, 4, 8 };
| ^~~~~~~~~~~~~~~~~~
lib/zstd/compress/zstd_compress.c: In function 'ZSTD_compress':
>> lib/zstd/compress/zstd_compress.c:3252:1: warning: the frame size of 1084 bytes is larger than 1024 bytes [-Wframe-larger-than=]
3252 | }
| ^
--
In file included from lib/zstd/compress/zstd_compress_superblock.c:16:
lib/zstd/compress/../common/zstd_internal.h:148:21: warning: 'ZSTD_did_fieldSize' defined but not used [-Wunused-const-variable=]
148 | static const size_t ZSTD_did_fieldSize[4] = { 0, 1, 2, 4 };
| ^~~~~~~~~~~~~~~~~~
lib/zstd/compress/../common/zstd_internal.h:147:21: warning: 'ZSTD_fcs_fieldSize' defined but not used [-Wunused-const-variable=]
147 | static const size_t ZSTD_fcs_fieldSize[4] = { 0, 2, 4, 8 };
| ^~~~~~~~~~~~~~~~~~
lib/zstd/compress/../common/zstd_internal.h:133:18: warning: 'repStartValue' defined but not used [-Wunused-const-variable=]
133 | static const U32 repStartValue[ZSTD_REP_NUM] = { 1, 4, 8 };
| ^~~~~~~~~~~~~
In file included from lib/zstd/compress/zstd_compress_superblock.h:18,
from lib/zstd/compress/zstd_compress_superblock.c:14:
include/linux/zstd.h:1377:29: warning: 'ZSTD_defaultCMem' defined but not used [-Wunused-const-variable=]
1377 | static ZSTD_customMem const ZSTD_defaultCMem = { NULL, NULL, NULL }; /**< this constant defers to stdlib's functions */
| ^~~~~~~~~~~~~~~~
lib/zstd/compress/zstd_compress_superblock.c: In function 'ZSTD_compressSuperBlock':
>> lib/zstd/compress/zstd_compress_superblock.c:849:1: warning: the frame size of 1068 bytes is larger than 1024 bytes [-Wframe-larger-than=]
849 | }
| ^

# https://github.com/0day-ci/linux/commit/55f5799ba0242ead6cde3f9cd4d04b2a19384d37
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Nick-Terrell/Update-to-zstd-1-4-6/20200916-114901
git checkout 55f5799ba0242ead6cde3f9cd4d04b2a19384d37
vim +3252 lib/zstd/compress/zstd_compress.c

3241
3242 size_t ZSTD_compress(void* dst, size_t dstCapacity,
3243 const void* src, size_t srcSize,
3244 int compressionLevel)
3245 {
3246 size_t result;
3247 ZSTD_CCtx ctxBody;
3248 ZSTD_initCCtx(&ctxBody, ZSTD_defaultCMem);
3249 result = ZSTD_compressCCtx(&ctxBody, dst, dstCapacity, src, srcSize, compressionLevel);
3250 ZSTD_freeCCtxContent(&ctxBody); /* can't free ctxBody itself, as it's on stack; free only heap content */
3251 return result;
> 3252 }
3253

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 23267 bytes --]