Re: [PATCH v7 14/34] i2c: tegra: Clean up probe function

Andy Shevchenko
2020-09-17T14:08:09Z

On Thu, Sep 17, 2020 at 3:37 PM Thierry Reding <thierry.reding@gmail.com> wrote:
> On Wed, Sep 09, 2020 at 01:39:46AM +0300, Dmitry Osipenko wrote:

...

> > + ret = devm_request_irq(&pdev->dev, i2c_dev->irq, tegra_i2c_isr,
> > + IRQF_NO_SUSPEND, dev_name(&pdev->dev),
> > + i2c_dev);
> > + if (ret)
> > + return ret;
>
> Is it safe to install the interrupt handler at this point? What if,
> perhaps because some bootloader didn't properly quiesce the I2C
> controller, an interrupt triggers immediately after this?

It\s easy to check with debug shared IRQ, but here IRQ is not shared...
So, with a hack into the code and enabled debug it will be achievable to test.

And you probably meant that IRQ triggers *before* the handler is in place?

--
With Best Regards,
Andy Shevchenko