Re: [PATCH v7 08/34] i2c: tegra: Remove error message used for devm_request_irq() failure

Thierry Reding
2020-09-17T11:36:47Z

[-- Attachment #1: Type: text/plain, Size: 1509 bytes --]

On Wed, Sep 09, 2020 at 01:39:40AM +0300, Dmitry Osipenko wrote:
> The error message prints number of vIRQ, which isn't a useful information.
> In practice devm_request_irq() never fails, hence let's remove the bogus
> message in order to make code cleaner.
>
> Reviewed-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> drivers/i2c/busses/i2c-tegra.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

I think I have seen this fail occasionally when something's wrong in the
IRQ code, or when we are not properly configuring the IRQ in device tree
for example.

So I'd prefer if this error message stayed here. I agree that it's not a
terribly useful error message, so perhaps adding the error code to it
would make it more helpful?

Thierry

> diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
> index a52c72135390..b813c0976c10 100644
> --- a/drivers/i2c/busses/i2c-tegra.c
> +++ b/drivers/i2c/busses/i2c-tegra.c
> @@ -1807,10 +1807,8 @@ static int tegra_i2c_probe(struct platform_device *pdev)
>
> ret = devm_request_irq(&pdev->dev, i2c_dev->irq, tegra_i2c_isr,
> IRQF_NO_SUSPEND, dev_name(&pdev->dev), i2c_dev);
> - if (ret) {
> - dev_err(&pdev->dev, "Failed to request irq %i\n", i2c_dev->irq);
> + if (ret)
> goto release_dma;
> - }
>
> i2c_set_adapdata(&i2c_dev->adapter, i2c_dev);
> i2c_dev->adapter.owner = THIS_MODULE;
> --
> 2.27.0
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]