Re: [PATCH v7 14/34] i2c: tegra: Clean up probe function

Dmitry Osipenko
2020-09-17T15:05:08Z

17.09.2020 15:37, Thierry Reding пишет:
...
>> + /* interrupt will be enabled during of transfer time */
>> + irq_set_status_flags(i2c_dev->irq, IRQ_NOAUTOEN);
^^^^^^^^^^^^

>> + ret = devm_request_irq(&pdev->dev, i2c_dev->irq, tegra_i2c_isr,
>> + IRQF_NO_SUSPEND, dev_name(&pdev->dev),
>> + i2c_dev);
>> + if (ret)
>> + return ret;
>
> Is it safe to install the interrupt handler at this point? What if,
> perhaps because some bootloader didn't properly quiesce the I2C
> controller, an interrupt triggers immediately after this?

This is why we're using the IRQ_NOAUTOEN flag above :)