Re: [PATCH v7 05/34] i2c: tegra: Initialize div-clk rate unconditionally

Thierry Reding
2020-09-17T11:22:16Z

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

On Wed, Sep 09, 2020 at 01:39:37AM +0300, Dmitry Osipenko wrote:
> It doesn't make sense to conditionalize the div-clk rate changes because
> rate is fixed and it won't ever change once it's set at the driver's probe
> time. All further changes are NO-OPs because CCF caches rate and skips
> rate-change if rate is unchanged.
>
> Reviewed-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> drivers/i2c/busses/i2c-tegra.c | 34 ++++++++++++++++------------------
> 1 file changed, 16 insertions(+), 18 deletions(-)

Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]