Re: [PATCH v7 14/34] i2c: tegra: Clean up probe function

Thierry Reding
2020-09-21T11:17:24Z

[-- Attachment #1: Type: text/plain, Size: 863 bytes --]

On Thu, Sep 17, 2020 at 06:02:26PM +0300, Dmitry Osipenko wrote:
> 17.09.2020 15:37, Thierry Reding пишет:
> ...
> >> + /* interrupt will be enabled during of transfer time */
> >> + irq_set_status_flags(i2c_dev->irq, IRQ_NOAUTOEN);
> ^^^^^^^^^^^^
>
> >> + ret = devm_request_irq(&pdev->dev, i2c_dev->irq, tegra_i2c_isr,
> >> + IRQF_NO_SUSPEND, dev_name(&pdev->dev),
> >> + i2c_dev);
> >> + if (ret)
> >> + return ret;
> >
> > Is it safe to install the interrupt handler at this point? What if,
> > perhaps because some bootloader didn't properly quiesce the I2C
> > controller, an interrupt triggers immediately after this?
>
> This is why we're using the IRQ_NOAUTOEN flag above :)

Ah, I missed that. Seems fine then:

Reviewed-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]