Re: [PATCH v7 32/34] i2c: tegra: Clean up and improve comments

Thierry Reding
2020-09-21T11:44:16Z

[-- Attachment #1: Type: text/plain, Size: 1133 bytes --]

On Mon, Sep 21, 2020 at 01:43:20PM +0200, Thierry Reding wrote:
> On Thu, Sep 17, 2020 at 06:17:39PM +0300, Dmitry Osipenko wrote:
> > 17.09.2020 18:02, Dmitry Osipenko пишет:
> > > 17.09.2020 15:32, Thierry Reding пишет:
> > > ...
> > >>> /**
> > >>> - * struct tegra_i2c_hw_feature : Different HW support on Tegra
> > >>> - * @has_continue_xfer_support: Continue transfer supports.
> > >>> + * struct tegra_i2c_hw_feature : per hardware generation features
> > >>
> > >> I think that space before ':' can go away. Although that's preexisting,
> > >> so could also be a separate patch, I guess.
> > >
> > > I haven't even noticed that!
> > >
> >
> > Wait, that ':' is used only for the struct description, hence it
> > actually looks natural in the code.
>
> What makes the struct description different from the field descriptions?
> A description list is basically:
>
> <term>: <description>
>
> And it doesn't matter what exactly <term> is.

Anyway, like I said, this is preexisting, so we can always fix that up
in another patch:

Reviewed-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]