From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3A3CC43461 for ; Thu, 17 Sep 2020 19:02:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A140220717 for ; Thu, 17 Sep 2020 19:02:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600369336; bh=3JGWNB8c2qNysyg2H63u02x8rYe2epKRl1hQ1YYXCFg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=EUI3KrggTZMg/9s2zwNGJcBRUOOwcI8lsYJzLh9ukaecsLofm7+yteCLhBqRRRnEe tfpHyyXxbBnYd6dQu4qmDM4Xp1ki3HD5YKTMgAGix7zBFEvtG0pxIwNdSRMBjQ4kmj XVR8WrSApoct2Arq16tSqsHr2EOPZSOufnS5mmw8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726353AbgIQTB4 (ORCPT ); Thu, 17 Sep 2020 15:01:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:60534 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726667AbgIQTA3 (ORCPT ); Thu, 17 Sep 2020 15:00:29 -0400 Received: from quaco.ghostprotocols.net (unknown [179.97.37.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EA34B21973; Thu, 17 Sep 2020 19:00:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600369229; bh=3JGWNB8c2qNysyg2H63u02x8rYe2epKRl1hQ1YYXCFg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qzk+eKAqIZxb9O9BkJq7d0k4YLbKsoqob6kA/9KsyhcG1yUGlZhj1gnnQTqFpoI8R aeNx4IMzR9URbWUo1SVWenORu1OQ9vwKbEMp0pQDoXNvDkKIZmWGXFdhwSpprF/thR EAW4YSDrWGrjTc2hrzhcn0l4b+WIyFuDASgh0ql8= Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id F4226400E9; Thu, 17 Sep 2020 16:00:26 -0300 (-03) Date: Thu, 17 Sep 2020 16:00:26 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Namhyung Kim , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Kajol Jain , Kan Liang , Jin Yao , Thomas Richter , linux-kernel , Stephane Eranian Subject: Re: [PATCH v3] perf metricgroup: Fix uncore metric expressions Message-ID: <20200917190026.GB1426933@kernel.org> References: <20200910180231.786751-1-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Sep 11, 2020 at 12:07:35PM +0900, Namhyung Kim escreveu: > On Fri, Sep 11, 2020 at 3:02 AM Ian Rogers wrote: > > v3. cleans up searching for the same event within metric_events to use a > > helper and avoids a redundant search. It uses a continue loop to > > make the search for similarly named events shorter. > > v2. avoids iterating over the whole evlist as suggested by > > namhyung@kernel.org. It also fixes the metric_leader computation > > that was broken in the same commits. > > > > Erroneous duplication introduced in: > > commit 2440689d62e9 ("perf metricgroup: Remove duped metric group events"). > > > > Fixes: ded80bda8bc9 ("perf expr: Migrate expr ids table to a hashmap"). > > Reported-by: Jin Yao > > Signed-off-by: Ian Rogers > > Acked-by: Namhyung Kim On my perf/urgent branch (upstream should be the same): [acme@five perf]$ patch -p1 < /wb/1.patch patching file tools/perf/util/metricgroup.c Hunk #1 succeeded at 150 with fuzz 2 (offset 1 line). Hunk #2 succeeded at 192 (offset 1 line). Hunk #3 succeeded at 223 (offset 1 line). Hunk #4 succeeded at 252 (offset 1 line). Hunk #5 succeeded at 260 (offset 1 line). [acme@five perf]$ I'm fixing it up, please check that doing this is safe on your side. - Arnaldo