Re: [PATCH v6 0/7] perf: Stream comparison

Arnaldo Carvalho de Melo
2020-09-17T20:13:27Z

Em Thu, Sep 17, 2020 at 03:05:56PM +0200, Jiri Olsa escreveu:
> On Fri, Sep 11, 2020 at 04:03:46PM +0800, Jin Yao wrote:
>
> SNIP
>
> > main div.c:40
> > main div.c:40
> > main div.c:39
> >
> > [ Hot streams in new perf data only ]
> >
> > hot chain 1:
> > cycles: 4, hits: 4.54%
> > --------------------------
> > main div.c:42
> > compute_flag div.c:28
> >
> > hot chain 2:
> > cycles: 5, hits: 3.51%
> > --------------------------
> > main div.c:39
> > main div.c:44
> > main div.c:42
> > compute_flag div.c:28
> >
> > v6:
> > ---
> > Rebase to perf/core
>
> it looks good to me
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>

Jin,

I'm sorry I only got to look at this now, there are some issues,
I'll try to point them out patch by patch,

Thanks,

- Arnaldo