Re: [PATCH v6 7/7] perf diff: Support hot streams comparison

Jin, Yao
2020-09-19T04:42:31Z

Hi Arnaldo,

On 9/18/2020 4:26 AM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Sep 11, 2020 at 04:03:53PM +0800, Jin Yao escreveu:
>> This patch enables perf-diff with "--stream" option.
>>
>> "--stream": Enable hot streams comparison
>>
>> Now let's see examples.
>>
>> perf record -b ... Generate perf.data.old with branch data
>> perf record -b ... Generate perf.data with branch data
>> perf diff --stream
>>
>> [ Matched hot streams ]
>>
>> hot chain pair 1:
>> cycles: 1, hits: 27.77% cycles: 1, hits: 9.24%
>> --------------------------- --------------------------
>> main div.c:39 main div.c:39
>> main div.c:44 main div.c:44
>>
>> hot chain pair 2:
>> cycles: 34, hits: 20.06% cycles: 27, hits: 16.98%
>> --------------------------- --------------------------
>> __random_r random_r.c:360 __random_r random_r.c:360
>
> Would it be interesting to get the associated source code and show right below
> these file:number lines?
>
> - Arnaldo
>

I'm thinking we can implement this function in callchain_list__sym_name(), and then all callchain
functionality will benefit from it. While that looks to be another patchset. :)

Thanks
Jin Yao