From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42A2BC43464 for ; Fri, 18 Sep 2020 02:01:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B30C208E4 for ; Fri, 18 Sep 2020 02:01:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600394474; bh=YJPAtgg8ivm3iVpE20/kFIelrzzAGemuhbNoSxU16ms=; h=From:To:Cc:Subject:Date:List-ID:From; b=XTRXeslWOnFqP3wkJx7QssjMyqf9x7h9nso9gWgRbOyaTHL/+AP7ZE2LfUC+g3+Fy JqEu88UDbE2W72P6G4tvq3yJsRSRbHYKgu9X9lYEqGeSy0qBiwbpOyQ7wImQ4xsSF4 vfXY4sMa82dTJGF8sy3Er8B2Na7pwpbpkbrQpD68= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726200AbgIRCBN (ORCPT ); Thu, 17 Sep 2020 22:01:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:45268 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725886AbgIRCBM (ORCPT ); Thu, 17 Sep 2020 22:01:12 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C83BF20853; Fri, 18 Sep 2020 02:01:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600394472; bh=YJPAtgg8ivm3iVpE20/kFIelrzzAGemuhbNoSxU16ms=; h=From:To:Cc:Subject:Date:From; b=vqlSMF7HilJT/pNaff65vSD3vwNWGn5l7V22jvkl1n68NsRcHSkMbf/tVM+dK9z5q 97tuFwn7JZRnNEz/DtW4ZQldPZ+Wmqa6QYSTaQrAG9wQudYSoiByWguAThWm9XzCNq aFb2Y0RNWKSS/MZFDYtFysb8wkW4z8AY7QsbZufU= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Iago Toral Quiroga , Eric Anholt , Sasha Levin , dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 5.4 001/330] drm/v3d: don't leak bin job if v3d_job_init fails. Date: Thu, 17 Sep 2020 21:55:41 -0400 Message-Id: <20200918020110.2063155-1-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Iago Toral Quiroga [ Upstream commit 0d352a3a8a1f26168d09f7073e61bb4b328e3bb9 ] If the initialization of the job fails we need to kfree() it before returning. Signed-off-by: Iago Toral Quiroga Signed-off-by: Eric Anholt Link: https://patchwork.freedesktop.org/patch/msgid/20190916071125.5255-1-itoral@igalia.com Fixes: a783a09ee76d ("drm/v3d: Refactor job management.") Reviewed-by: Eric Anholt Signed-off-by: Sasha Levin --- drivers/gpu/drm/v3d/v3d_gem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c index 19c092d75266b..6316bf3646af5 100644 --- a/drivers/gpu/drm/v3d/v3d_gem.c +++ b/drivers/gpu/drm/v3d/v3d_gem.c @@ -565,6 +565,7 @@ v3d_submit_cl_ioctl(struct drm_device *dev, void *data, ret = v3d_job_init(v3d, file_priv, &bin->base, v3d_job_free, args->in_sync_bcl); if (ret) { + kfree(bin); v3d_job_put(&render->base); kfree(bin); return ret; -- 2.25.1