From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78360C43464 for ; Fri, 18 Sep 2020 02:31:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 35DAD22208 for ; Fri, 18 Sep 2020 02:31:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600396281; bh=SdhpDMJTj3MzvxIvsNNng0DO6JHm/lXM7QhxSrmJ4Ls=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=xaFMAOz+CTF/LM+RHmdqXILT7TMPV05KdkE4KBCl2MyGTW2cgmsyT6tRft6P7fkT9 Aa0FUdhwdp6eqmt39aC9qA5oG7uu5lbk2R/ZcqTY31ShLIj1OHuSOUPZO1f7bQyZ4P Q7zyIWp8Mr6Y7SWa/n1/DcIOsBtAtkLB8ae2oKyw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727320AbgIRCbU (ORCPT ); Thu, 17 Sep 2020 22:31:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:42510 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729075AbgIRCO0 (ORCPT ); Thu, 17 Sep 2020 22:14:26 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 413CE2399C; Fri, 18 Sep 2020 02:14:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600395262; bh=SdhpDMJTj3MzvxIvsNNng0DO6JHm/lXM7QhxSrmJ4Ls=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nVnJctyft5UcJyoUez4CCZd3IKCERQH6RRkNFqdT2rOV9uC9aEXYmE0mjd82oTL47 /5vIVsv4EWJnLWhduXvakeaAGRRxPd3rW6ApY+qU/MRanzhYLTmaGLJ09SRpkSwZHz 8AVS0l+B773ajlyI0EWrjFcu1Z+MdkxCzxuSOuJQ= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Miklos Szeredi , Matthew Wilcox , Sasha Levin , fuse-devel@lists.sourceforge.net Subject: [PATCH AUTOSEL 4.14 103/127] fuse: don't check refcount after stealing page Date: Thu, 17 Sep 2020 22:11:56 -0400 Message-Id: <20200918021220.2066485-103-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200918021220.2066485-1-sashal@kernel.org> References: <20200918021220.2066485-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miklos Szeredi [ Upstream commit 32f98877c57bee6bc27f443a96f49678a2cd6a50 ] page_count() is unstable. Unless there has been an RCU grace period between when the page was removed from the page cache and now, a speculative reference may exist from the page cache. Reported-by: Matthew Wilcox Signed-off-by: Miklos Szeredi Signed-off-by: Sasha Levin --- fs/fuse/dev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c index f580695b7bb9a..1b9c4c19bed29 100644 --- a/fs/fuse/dev.c +++ b/fs/fuse/dev.c @@ -824,7 +824,6 @@ static int fuse_check_page(struct page *page) { if (page_mapcount(page) || page->mapping != NULL || - page_count(page) != 1 || (page->flags & PAGE_FLAGS_CHECK_AT_PREP & ~(1 << PG_locked | 1 << PG_referenced | -- 2.25.1