From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D353C43463 for ; Fri, 18 Sep 2020 02:37:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F4A423770 for ; Fri, 18 Sep 2020 02:37:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600396621; bh=tRfPMEK6EgPgwCmyDz52kwhFQzirjlhRXhN8bUwPkic=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=cm/rN8baPwMwEtY24XCmYA3a3do56UgcriR6D2AsOTsewDRGf1YnNOZHgLceaTfzE o1Usw52MMmdJFG9soYy3c7c65Y+JWirDng87ol1e/9wL6ZvmPM1yLv5ARZ1HC1fNyn 9alJwVwz1bbtkpbjBsEPuCW62T1qGEaDvAuI0dw4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730082AbgIRChA (ORCPT ); Thu, 17 Sep 2020 22:37:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:39486 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728827AbgIRCMs (ORCPT ); Thu, 17 Sep 2020 22:12:48 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 31B9D2388D; Fri, 18 Sep 2020 02:12:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600395167; bh=tRfPMEK6EgPgwCmyDz52kwhFQzirjlhRXhN8bUwPkic=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ntkvs/AqeOETxyfX/m6vIcx+VDppX39sXSV0hSdHQnem3OxSr0z/fVNB7OtoCAvel dgsbuNFDHMl75OuMwrTlBTiqU0iyDhbrHF7m7XkUOPygt5Yt8fkYk5pA8lUprOVQbi R/Nufyr8SCOJ9dh3qzyDsOeU2Ra2hiuq6tr+Qizw= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Vasily Averin , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 024/127] neigh_stat_seq_next() should increase position index Date: Thu, 17 Sep 2020 22:10:37 -0400 Message-Id: <20200918021220.2066485-24-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200918021220.2066485-1-sashal@kernel.org> References: <20200918021220.2066485-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vasily Averin [ Upstream commit 1e3f9f073c47bee7c23e77316b07bc12338c5bba ] if seq_file .next fuction does not change position index, read after some lseek can generate unexpected output. https://bugzilla.kernel.org/show_bug.cgi?id=206283 Signed-off-by: Vasily Averin Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/core/neighbour.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/core/neighbour.c b/net/core/neighbour.c index 567e431813e59..20f6c634ad68a 100644 --- a/net/core/neighbour.c +++ b/net/core/neighbour.c @@ -2836,6 +2836,7 @@ static void *neigh_stat_seq_next(struct seq_file *seq, void *v, loff_t *pos) *pos = cpu+1; return per_cpu_ptr(tbl->stats, cpu); } + (*pos)++; return NULL; } -- 2.25.1