From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EDDAC43463 for ; Fri, 18 Sep 2020 02:32:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1607623600 for ; Fri, 18 Sep 2020 02:32:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600396329; bh=lVG0d6wPGSDQKOc16I8PEI+vekJhX9d2zaV6R5LF1jQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Uh3cOLErBrvtMarI46pFOVcrJZiBsMqv3APufmzKwXqJw73G9J0bZ5lA/fQKeeBFM 8HorOv1JgYmuRS2c+qK6s/+0zPwM1Iw/EkP/nZtp9guRqqV2MIsvRZNRo8OrD8viPw wNH8UmRnhA4SM4k+R7sEbdDaO9lVPgO6qHBMtmAA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729942AbgIRCcG (ORCPT ); Thu, 17 Sep 2020 22:32:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:42016 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729020AbgIRCOJ (ORCPT ); Thu, 17 Sep 2020 22:14:09 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4A8C2238E6; Fri, 18 Sep 2020 02:14:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600395248; bh=lVG0d6wPGSDQKOc16I8PEI+vekJhX9d2zaV6R5LF1jQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qzQjCV38t0ILxhbl/T9Q5+WcESeJn3B5dqMZzMhPKyo5kMdvhGwbBZIh25PaLUfBk kw9c36VxG1r85+SlCDmTERWKgP7zJw/fWDRPIZ8/L4bORWZomUE9qr8Jia00zJ4Oq7 v+Z7kBryvxO4m9hHuMRnjnsd6OKiv3vuquZRyHSE= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Wei Yongjun , Greg Kroah-Hartman , Sasha Levin Subject: [PATCH AUTOSEL 4.14 091/127] sparc64: vcc: Fix error return code in vcc_probe() Date: Thu, 17 Sep 2020 22:11:44 -0400 Message-Id: <20200918021220.2066485-91-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200918021220.2066485-1-sashal@kernel.org> References: <20200918021220.2066485-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wei Yongjun [ Upstream commit ff62255a2a5c1228a28f2bb063646f948115a309 ] Fix to return negative error code -ENOMEM from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun Link: https://lore.kernel.org/r/20200427122415.47416-1-weiyongjun1@huawei.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/vcc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/vcc.c b/drivers/tty/vcc.c index ef01d24858cd6..4e795353192bc 100644 --- a/drivers/tty/vcc.c +++ b/drivers/tty/vcc.c @@ -612,6 +612,7 @@ static int vcc_probe(struct vio_dev *vdev, const struct vio_device_id *id) port->index = vcc_table_add(port); if (port->index == -1) { pr_err("VCC: no more TTY indices left for allocation\n"); + rv = -ENOMEM; goto free_ldc; } -- 2.25.1