From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64441C43464 for ; Fri, 18 Sep 2020 02:23:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F97E23119 for ; Fri, 18 Sep 2020 02:23:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600395829; bh=CVPW74+9iUazKpNrnSz1iSUUIDw1aqFx0ULsHc0BPkM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Sjh05tz7YMNjN/tZHKB40tDX2qJQK2kEnJu9eKf7aBcF07/oCoq4900XKzhNZvkb9 Y8vIeIfcTHhjcRJobV+/u7jPAFjxFds/jvhlUPBGFSBUhsD9KW0KD82B9PHOr3mBiC a6UBxAR0yP9u3cV+l6LQ2zQOyVc4gSmlrOeqxuCo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729289AbgIRCXr (ORCPT ); Thu, 17 Sep 2020 22:23:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:46816 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729450AbgIRCQs (ORCPT ); Thu, 17 Sep 2020 22:16:48 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1000723718; Fri, 18 Sep 2020 02:16:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600395407; bh=CVPW74+9iUazKpNrnSz1iSUUIDw1aqFx0ULsHc0BPkM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kDnxff9Ec3l5zoOIDkUGrxzhqAebHWf1DKH2ioEwtrI48lnEQY5PmHzr2k2wUBKSE k7PsN/u5VdJDc5Nu0ClLvKMX9x+78DTCYPwRdHiHIsyGJ6ZsTclMcfa+/t/hArYJm7 MfBCt6PGinY+7KvRLCFT9puQJHanjcEtC+isOv98= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Kangjie Lu , Daniel Vetter , Sasha Levin , dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 4.4 03/64] gma/gma500: fix a memory disclosure bug due to uninitialized bytes Date: Thu, 17 Sep 2020 22:15:42 -0400 Message-Id: <20200918021643.2067895-3-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200918021643.2067895-1-sashal@kernel.org> References: <20200918021643.2067895-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kangjie Lu [ Upstream commit 57a25a5f754ce27da2cfa6f413cfd366f878db76 ] `best_clock` is an object that may be sent out. Object `clock` contains uninitialized bytes that are copied to `best_clock`, which leads to memory disclosure and information leak. Signed-off-by: Kangjie Lu Signed-off-by: Daniel Vetter Link: https://patchwork.freedesktop.org/patch/msgid/20191018042953.31099-1-kjlu@umn.edu Signed-off-by: Sasha Levin --- drivers/gpu/drm/gma500/cdv_intel_display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/gma500/cdv_intel_display.c b/drivers/gpu/drm/gma500/cdv_intel_display.c index 7d47b3d5cc0d0..54d554d720004 100644 --- a/drivers/gpu/drm/gma500/cdv_intel_display.c +++ b/drivers/gpu/drm/gma500/cdv_intel_display.c @@ -415,6 +415,8 @@ static bool cdv_intel_find_dp_pll(const struct gma_limit_t *limit, struct gma_crtc *gma_crtc = to_gma_crtc(crtc); struct gma_clock_t clock; + memset(&clock, 0, sizeof(clock)); + switch (refclk) { case 27000: if (target < 200000) { -- 2.25.1