Re: [PATCH 2/4] ARM/footbridge: switch to use dma_direct_set_offset for lbus DMA offsets

Russell King - ARM Linux admin
2020-09-17T18:54:15Z

On Thu, Sep 17, 2020 at 07:32:27PM +0200, Christoph Hellwig wrote:
> static int __init cats_pci_init(void)
> {
> - if (machine_is_cats())
> - pci_common_init(&cats_pci);
> + if (!machine_is_cats())
> + return 0;
> + bus_register_notifier(&pci_bus_type, &footbridge_pci_dma_nb);
> + pci_common_init(&cats_pci);

I'd prefer these things to retain a positive-logic construct, so:

if (machine_is_cats()) {
bus_register_notifier(&pci_bus_type, &footbridge_pci_dma_nb);
pci_common_init(&cats_pci);
}

It's the same number of lines.

Otherwise, I think it's fine. I'll try to find some spare time to give
it a go on a Netwinder.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!