From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: Jing Xiangfeng <jingxiangfeng@huawei.com>
Cc: jejb@linux.ibm.com, martin.petersen@oracle.com,
lee.jones@linaro.org, colin.king@canonical.com, axboe@kernel.dk,
mchehab+huawei@kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: arcmsr: Remove the superfluous break
Date: Fri, 18 Sep 2020 09:56:19 -0500 [thread overview]
Message-ID: <20200918145619.GA25599@embeddedor> (raw)
In-Reply-To: <20200918093230.49050-1-jingxiangfeng@huawei.com>
On Fri, Sep 18, 2020 at 05:32:30PM +0800, Jing Xiangfeng wrote:
> Remove the superfluous break, as there is a 'return' before it.
>
Apparently, the change is correct. Please, just add a proper Fixes tag by
yourself this time.
Thanks
--
Gustavo
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
> ---
> drivers/scsi/arcmsr/arcmsr_hba.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
> index ec895d0319f0..74add6d247d5 100644
> --- a/drivers/scsi/arcmsr/arcmsr_hba.c
> +++ b/drivers/scsi/arcmsr/arcmsr_hba.c
> @@ -2699,10 +2699,8 @@ static irqreturn_t arcmsr_interrupt(struct AdapterControlBlock *acb)
> switch (acb->adapter_type) {
> case ACB_ADAPTER_TYPE_A:
> return arcmsr_hbaA_handle_isr(acb);
> - break;
> case ACB_ADAPTER_TYPE_B:
> return arcmsr_hbaB_handle_isr(acb);
> - break;
> case ACB_ADAPTER_TYPE_C:
> return arcmsr_hbaC_handle_isr(acb);
> case ACB_ADAPTER_TYPE_D:
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-09-18 14:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 9:32 [PATCH] scsi: arcmsr: Remove the superfluous break Jing Xiangfeng
2020-09-18 14:56 ` Gustavo A. R. Silva [this message]
2020-09-18 17:13 ` Joe Perches
2020-09-18 17:17 ` Jens Axboe
2020-09-18 19:07 ` Joe Perches
2020-09-18 18:00 ` Dan Carpenter
2020-09-18 18:03 ` Colin Ian King
2020-09-19 1:52 ` Jing Xiangfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918145619.GA25599@embeddedor \
--to=gustavoars@kernel.org \
--cc=axboe@kernel.dk \
--cc=colin.king@canonical.com \
--cc=jejb@linux.ibm.com \
--cc=jingxiangfeng@huawei.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mchehab+huawei@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox