From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CAA9C43464 for ; Sat, 19 Sep 2020 06:22:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE97122211 for ; Sat, 19 Sep 2020 06:22:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600496555; bh=Kuxz2KrdTf20dNUtZmk07m7aaNkacgtNpBvw3SbUQYw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=W2zMTNGpZeRrFIxXOIOeNIi6svi2j36k/xLCsCxiHXfivwfUrHhvAUI3ruJGJtNRI gaCElopRjtrdGOSfnXOSALrXRRYIGwFox0qixprJh7voYn5YE87mhI8N9EO+soXhvk pMyu0istRAH8GDyyGszWkorB4Jp9INDm/V4HyZ9U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726293AbgISGWe (ORCPT ); Sat, 19 Sep 2020 02:22:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:34172 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726129AbgISGWe (ORCPT ); Sat, 19 Sep 2020 02:22:34 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E5B1222208; Sat, 19 Sep 2020 06:22:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600496553; bh=Kuxz2KrdTf20dNUtZmk07m7aaNkacgtNpBvw3SbUQYw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aH6o+6KJlF936JU2BCeVAUcxGQ/1gZEVmZcXoqFYc60DOttLJNcVoRL1mpBaYL5U6 MAFlBhaIVxRRNStv/oLtoo1Zl/199MRZs1GlgXN5Lijz19bh9crAinFJoScH+lIE3R v1e+4bCe08tdcmWrOFkSjNuvabUHL0WDZTvaE9uQ= Date: Sat, 19 Sep 2020 08:22:28 +0200 From: Greg Kroah-Hartman To: Joe Perches Cc: "Rafael J . Wysocki" , Mike Kravetz , Andrew Morton , Denis Efremov , Julia Lawall , Alex Dewar , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH V3 6/8] mm: and drivers core: Convert hugetlb_report_node_meminfo to sysfs_emit Message-ID: <20200919062228.GA438957@kroah.com> References: <894b351b82da6013cde7f36ff4b5493cd0ec30d0.1600285923.git.joe@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <894b351b82da6013cde7f36ff4b5493cd0ec30d0.1600285923.git.joe@perches.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 16, 2020 at 01:40:43PM -0700, Joe Perches wrote: > Convert the unbound sprintf in hugetlb_report_node_meminfo to use > sysfs_emit_at so that no possible overrun of a PAGE_SIZE buf can occur. > > Signed-off-by: Joe Perches > --- > drivers/base/node.c | 2 +- > include/linux/hugetlb.h | 4 ++-- > mm/hugetlb.c | 18 ++++++++++-------- > 3 files changed, 13 insertions(+), 11 deletions(-) > > diff --git a/drivers/base/node.c b/drivers/base/node.c > index b33526a9fcfc..dafe03e82e7c 100644 > --- a/drivers/base/node.c > +++ b/drivers/base/node.c > @@ -473,7 +473,7 @@ static ssize_t node_read_meminfo(struct device *dev, > HPAGE_PMD_NR) > #endif > ); > - len += hugetlb_report_node_meminfo(nid, buf + len); > + len += hugetlb_report_node_meminfo(buf, len, nid); > return len; > } > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index d5cc5f802dd4..ebca2ef02212 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -129,7 +129,7 @@ void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma, > unsigned long start, unsigned long end, > struct page *ref_page); > void hugetlb_report_meminfo(struct seq_file *); > -int hugetlb_report_node_meminfo(int, char *); > +int hugetlb_report_node_meminfo(char *buf, int len, int nid); > void hugetlb_show_meminfo(void); > unsigned long hugetlb_total_pages(void); > vm_fault_t hugetlb_fault(struct mm_struct *mm, struct vm_area_struct *vma, > @@ -245,7 +245,7 @@ static inline void hugetlb_report_meminfo(struct seq_file *m) > { > } > > -static inline int hugetlb_report_node_meminfo(int nid, char *buf) > +static inline int hugetlb_report_node_meminfo(char *buf, int len, int nid) > { > return 0; > } > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 61469fd3ad92..fe76f8fd5a73 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -3571,18 +3571,20 @@ void hugetlb_report_meminfo(struct seq_file *m) > seq_printf(m, "Hugetlb: %8lu kB\n", total / 1024); > } > > -int hugetlb_report_node_meminfo(int nid, char *buf) > +int hugetlb_report_node_meminfo(char *buf, int len, int nid) > { > struct hstate *h = &default_hstate; > + > if (!hugepages_supported()) > return 0; > - return sprintf(buf, > - "Node %d HugePages_Total: %5u\n" > - "Node %d HugePages_Free: %5u\n" > - "Node %d HugePages_Surp: %5u\n", > - nid, h->nr_huge_pages_node[nid], > - nid, h->free_huge_pages_node[nid], > - nid, h->surplus_huge_pages_node[nid]); > + > + return sysfs_emit_at(buf, len, > + "Node %d HugePages_Total: %5u\n" > + "Node %d HugePages_Free: %5u\n" > + "Node %d HugePages_Surp: %5u\n", > + nid, h->nr_huge_pages_node[nid], > + nid, h->free_huge_pages_node[nid], > + nid, h->surplus_huge_pages_node[nid]); > } That is NOT one-value-per-file, which is required for sysfs files. This should be 3 different sysfs files. Ugh. But that's separate from this series, thanks for redoing this. I'll take a look at it on Monday... thanks, greg k-h