From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D8B2C43463 for ; Sun, 20 Sep 2020 14:05:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDDA621531 for ; Sun, 20 Sep 2020 14:05:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600610737; bh=Z9d9tah8JqHOP5pL4YoUeFKHAnNfZixgM4oEIn6E09o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=snc+/+JyXvYq2Iw4Jk+0spFALVJ+v1/tLcciNpTRjxUkaKHVm9gud3cnQk8PK7hye wHUiRTkV62igDK1PmWp1ioJrVNYuRL2xUTU1jAm7mJ+ps//67IT9uCWcSkQwCm+TR5 6bo/Q18rz+hTQNcqhg9deYitQ94ttsOx4oKxljFE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726367AbgITOFg (ORCPT ); Sun, 20 Sep 2020 10:05:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:33308 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726267AbgITOFg (ORCPT ); Sun, 20 Sep 2020 10:05:36 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AE4F32073A; Sun, 20 Sep 2020 14:05:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600610736; bh=Z9d9tah8JqHOP5pL4YoUeFKHAnNfZixgM4oEIn6E09o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t1rWOtUIWoQhkhK+H8uAHB/270vd84ch2gS+q+T01vLu2Hzs4ShnDXVb38Eehh7S1 XFOpt9uaDn+Caqd4yEVGc1R1mBZzociuhUb6HHlIHtqZS974z2SM6Z4XdMPHZwYOPF tKmjbC0qD0gQp3tcXanrLTgucXcmaoWVSEZ3dKik= Date: Sun, 20 Sep 2020 10:05:34 -0400 From: Sasha Levin To: Vincent Whitchurch Cc: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Mark Brown Subject: Re: [PATCH AUTOSEL 4.14 05/15] regulator: pwm: Fix machine constraints application Message-ID: <20200920140534.GK2431@sasha-vm> References: <20200914130526.1804913-1-sashal@kernel.org> <20200914130526.1804913-5-sashal@kernel.org> <20200915075508.jddoubwnptjcqtru@axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200915075508.jddoubwnptjcqtru@axis.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 15, 2020 at 09:55:08AM +0200, Vincent Whitchurch wrote: >On Mon, Sep 14, 2020 at 03:05:16PM +0200, Sasha Levin wrote: >> From: Vincent Whitchurch >> >> [ Upstream commit 59ae97a7a9e1499c2070e29841d1c4be4ae2994a ] >> >> If the zero duty cycle doesn't correspond to any voltage in the voltage >> table, the PWM regulator returns an -EINVAL from get_voltage_sel() which >> results in the core erroring out with a "failed to get the current >> voltage" and ending up not applying the machine constraints. >> >> Instead, return -ENOTRECOVERABLE which makes the core set the voltage >> since it's at an unknown value. > >For this patch to work it needs 84b3a7c9c6befe5ab4d49070fe7 ("regulator: >core: Allow for regulators that can't be read at bootup") which was >merged in v4.18. Without that this patch is not going to have any >effect so it probably shouldn't be backported to older kernels. Dropped for those older kernels, thanks! -- Thanks, Sasha