Re: ledtrig-cpu: Limit to 4 CPUs

Pavel Machek
2020-09-20T18:34:07Z

[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]

Hi!

> > *
> > * It can be bound to any LED just like other triggers using either a
> > * board file or via sysfs interface.
> > *
> > * An API named ledtrig_cpu is exported for any user, who want to add CPU
> > - * activity indication in their code
> > + * activity indication in their code.
> > *
> > * Copyright 2011 Linus Walleij <linus.walleij@linaro.org>
> > * Copyright 2011 - 2012 Bryan Wu <bryan.wu@canonical.com>
> > @@ -145,6 +149,9 @@ static int __init ledtrig_cpu_init(void)
> > for_each_possible_cpu(cpu) {
> > struct led_trigger_cpu *trig = &per_cpu(cpu_trig, cpu);
> > + if (cpu > 4)
>
> NACK. The workaround for this trigger was implemented for a reason -
> to make it working on platforms with arbitrary number of logical cpus.
> I've got 8, so I am discriminated now. Not saying, that it precludes
> trigger registration with no single line of warning.

Can I get details of your setup?

What CPU type that is, and how are you mapping CPU activity to LEDs?

Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]