From: Arvind Sankar <nivedita@alum.mit.edu>
To: Borislav Petkov <bp@alien8.de>
Cc: Arvind Sankar <nivedita@alum.mit.edu>, x86-ml <x86@kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] Use feature bit names in clearcpuid=
Date: Sun, 20 Sep 2020 14:35:27 -0400 [thread overview]
Message-ID: <20200920183527.GA3970023@rani.riverdale.lan> (raw)
In-Reply-To: <20200920172954.GC7473@zn.tnic>
On Sun, Sep 20, 2020 at 07:29:54PM +0200, Borislav Petkov wrote:
> On Sun, Sep 20, 2020 at 12:16:28PM -0400, Arvind Sankar wrote:
> > Allowing 13:24 as input would be icing on the cake :)
>
> Well, I'm kinda "meh" on that. Why, you ask?
>
> Well, whether the user multiplies two integers or the kernel does it for
> her/him, I'd prefer the user.
>
> But that's not even the problem - whether the product of the word number
> and the bit within that word, or the two supplied as a pair - either is
> the wrong interface. It is ugly and not even close to even beginning to
> be user-friendly.
>
> However, we can't make it fully user-friendly yet because not all bits
> have names. :-\
>
> But you know what, that doesn't matter too because that clearcpuid=
> thing is mainly for poking at sh*t and testing, not meant for users.
> Thus the tainting...
>
> So I guess the one who needs it, can go the minute distance and do the
> multiplication. According to that argument, adding the string parsing is
> not really needed too, but it is simple enough so WTH.
>
> I've incorporated all your other comments, see below.
>
> Thx!
>
Thanks. Maybe also mention in the documentation that names can now be
used.
next prev parent reply other threads:[~2020-09-20 18:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-20 15:42 [RFC PATCH] Use feature bit names in clearcpuid= Borislav Petkov
2020-09-20 16:16 ` Arvind Sankar
2020-09-20 17:29 ` Borislav Petkov
2020-09-20 18:35 ` Arvind Sankar [this message]
2020-09-20 18:59 ` Borislav Petkov
2020-09-22 8:03 ` Thomas Gleixner
2020-09-22 8:13 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200920183527.GA3970023@rani.riverdale.lan \
--to=nivedita@alum.mit.edu \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox