From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 874AAC43463 for ; Sun, 20 Sep 2020 20:26:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3405720866 for ; Sun, 20 Sep 2020 20:26:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600633596; bh=1JV3U23S6iZWo8OyR5/6orDz5B/HTrg7u+h7fk4d768=; h=From:To:Cc:Subject:Date:List-ID:From; b=MZ2B271zB/dbqtwRHYnPMFqS2tX6ZATJDf2EZ9vxOLPB32C+iaqDBS0RlMndvIfNK uYghn4k4EvdRJwJaOLloiN9EgUgbg4/AC08DgmW4DRrpa47PUW0Ryn08xA0poDAvTe KGdbH5I+t9fmhIzQgpZf/lE60s4WDdlFme+XOc5A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726365AbgITU0e (ORCPT ); Sun, 20 Sep 2020 16:26:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:47768 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726126AbgITU0c (ORCPT ); Sun, 20 Sep 2020 16:26:32 -0400 Received: from localhost.localdomain (unknown [194.230.155.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 34E9820795; Sun, 20 Sep 2020 20:26:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600633592; bh=1JV3U23S6iZWo8OyR5/6orDz5B/HTrg7u+h7fk4d768=; h=From:To:Cc:Subject:Date:From; b=vVR7pUBwadaWytc2eZco2+SI+iPTDuCKlO1vZSpr/8fTQOG4LdvdM9ZCx5Ln+/3tV gXlwDb7IZiYOuSaFOiaMtzriIHOBzlkFc9IA/NAy0XE+sd1Q7TWhmGsH7ejmUSqtTR daa/9GqU08lnb9I7v703avdtxdZsUWHyq2XvorJU= From: Krzysztof Kozlowski To: Li Yang , Roy Pledge , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH] soc: fsl: qbman: Fix return value on success Date: Sun, 20 Sep 2020 22:26:25 +0200 Message-Id: <20200920202625.11377-1-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On error the function was meant to return -ERRNO. This also fixes compile warning: drivers/soc/fsl/qbman/bman.c:640:6: warning: variable 'err' set but not used [-Wunused-but-set-variable] Fixes: 0505d00c8dba ("soc/fsl/qbman: Cleanup buffer pools if BMan was initialized prior to bootup") Signed-off-by: Krzysztof Kozlowski --- drivers/soc/fsl/qbman/bman.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/fsl/qbman/bman.c b/drivers/soc/fsl/qbman/bman.c index f4fb527d8301..c5dd026fe889 100644 --- a/drivers/soc/fsl/qbman/bman.c +++ b/drivers/soc/fsl/qbman/bman.c @@ -660,7 +660,7 @@ int bm_shutdown_pool(u32 bpid) } done: put_affine_portal(); - return 0; + return err; } struct gen_pool *bm_bpalloc; -- 2.17.1