From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FF3DC43463 for ; Mon, 21 Sep 2020 06:34:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BEE1320758 for ; Mon, 21 Sep 2020 06:34:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726328AbgIUGeR (ORCPT ); Mon, 21 Sep 2020 02:34:17 -0400 Received: from verein.lst.de ([213.95.11.211]:38614 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726242AbgIUGeR (ORCPT ); Mon, 21 Sep 2020 02:34:17 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 4734568AFE; Mon, 21 Sep 2020 08:34:14 +0200 (CEST) Date: Mon, 21 Sep 2020 08:34:13 +0200 From: Christoph Hellwig To: Xianting Tian Cc: kbusch@kernel.org, axboe@fb.com, hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme: replace meaningless judgement by checking whether req is null Message-ID: <20200921063413.GA18298@lst.de> References: <20200921021052.10462-1-tian.xianting@h3c.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200921021052.10462-1-tian.xianting@h3c.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks, this looks much more sensible than the previous versions.