From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Dr. David Alan Gilbert" <dave@treblig.org>
Cc: kbuild@lists.01.org, lkp@intel.com, kbuild-all@lists.01.org,
linux-kernel@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>
Subject: Re: [CRM114spam]: drivers/hwmon/w83627ehf.c:2417 w83627ehf_probe() warn: 'res->start' not released on lines: 2412.
Date: Mon, 21 Sep 2020 12:20:29 +0300 [thread overview]
Message-ID: <20200921092029.GU18329@kadam> (raw)
In-Reply-To: <20200920174954.GA25438@gallifrey>
On Sun, Sep 20, 2020 at 06:49:54PM +0100, Dr. David Alan Gilbert wrote:
> * Dan Carpenter (dan.carpenter@oracle.com) wrote:
> > b84bb5186297d1 drivers/hwmon/w83627ehf.c Guenter Roeck 2011-02-13 2405
> > 266cd5835947d0 drivers/hwmon/w83627ehf.c Dr. David Alan Gilbert 2019-11-24 2406 hwmon_dev = devm_hwmon_device_register_with_info(&pdev->dev,
> > 266cd5835947d0 drivers/hwmon/w83627ehf.c Dr. David Alan Gilbert 2019-11-24 2407 data->name,
> > 266cd5835947d0 drivers/hwmon/w83627ehf.c Dr. David Alan Gilbert 2019-11-24 2408 data,
> > 266cd5835947d0 drivers/hwmon/w83627ehf.c Dr. David Alan Gilbert 2019-11-24 2409 &w83627ehf_chip_info,
> > 266cd5835947d0 drivers/hwmon/w83627ehf.c Dr. David Alan Gilbert 2019-11-24 2410 w83627ehf_groups);
> > 08c79950a047db drivers/hwmon/w83627ehf.c Rudolf Marek 2006-07-05 2411
> > 266cd5835947d0 drivers/hwmon/w83627ehf.c Dr. David Alan Gilbert 2019-11-24 2412 return PTR_ERR_OR_ZERO(hwmon_dev);
> > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > This should be:
> >
> > if (IS_ERR(hwmon_dev)) {
> > err = PTR_ERR(hwmon_dev);
> > goto exit_release;
> > }
> >
> > return 0;
>
> That looks about right to me; why don't you just submit that as a patch ?
These are automated emails sent from a bot. I just look them over and
hit send. A lot of the time they are for patches which aren't applied
to a git tree yet.
But in this case, sure I can send an email. I looked at this one a bit
closely because it's a new warning that was only introduced last week.
regards,
dan carpenter
prev parent reply other threads:[~2020-09-21 9:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 9:41 drivers/hwmon/w83627ehf.c:2417 w83627ehf_probe() warn: 'res->start' not released on lines: 2412 Dan Carpenter
2020-09-20 17:49 ` [CRM114spam]: " Dr. David Alan Gilbert
2020-09-21 9:20 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200921092029.GU18329@kadam \
--to=dan.carpenter@oracle.com \
--cc=dave@treblig.org \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox