From: Wolfram Sang <wsa@kernel.org>
To: trix@redhat.com
Cc: syniurge@gmail.com, nehal-bakulchandra.shah@amd.com,
shyam-sundar.s-k@amd.com, natechancellor@gmail.com,
ndesaulniers@google.com, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH] i2c: amd_mp2: handle num is 0 input for i2c_amd_xfer
Date: Mon, 21 Sep 2020 11:39:14 +0200 [thread overview]
Message-ID: <20200921093914.GJ1840@ninjato> (raw)
In-Reply-To: <20200904180647.21080-1-trix@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 637 bytes --]
On Fri, Sep 04, 2020 at 11:06:47AM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> clang static analyzer reports this problem
>
> i2c-amd-mp2-plat.c:174:9: warning: Branch condition evaluates
> to a garbage value
> return err ? err : num;
> ^~~
>
> err is not initialized, it depends on the being set in the
> transfer loop which will not happen if num is 0. Surveying
> other master_xfer() implementations show all handle a 0 num.
>
> Because returning 0 is expected, initialize err to 0.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-09-21 9:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 18:06 [PATCH] i2c: amd_mp2: handle num is 0 input for i2c_amd_xfer trix
2020-09-05 12:33 ` Elie Morisse
2020-09-07 14:28 ` Wolfram Sang
2020-09-21 9:39 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200921093914.GJ1840@ninjato \
--to=wsa@kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=nehal-bakulchandra.shah@amd.com \
--cc=shyam-sundar.s-k@amd.com \
--cc=syniurge@gmail.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox