From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Jin, Yao" <yao.jin@linux.intel.com>
Cc: jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v6 7/7] perf diff: Support hot streams comparison
Date: Mon, 21 Sep 2020 09:17:00 -0300 [thread overview]
Message-ID: <20200921121700.GH1996959@kernel.org> (raw)
In-Reply-To: <a0eabcde-d498-2ec5-af4f-998380951782@linux.intel.com>
Em Sat, Sep 19, 2020 at 12:41:35PM +0800, Jin, Yao escreveu:
> Hi Arnaldo,
>
> On 9/18/2020 4:26 AM, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Sep 11, 2020 at 04:03:53PM +0800, Jin Yao escreveu:
> > > This patch enables perf-diff with "--stream" option.
> > >
> > > "--stream": Enable hot streams comparison
> > >
> > > Now let's see examples.
> > >
> > > perf record -b ... Generate perf.data.old with branch data
> > > perf record -b ... Generate perf.data with branch data
> > > perf diff --stream
> > >
> > > [ Matched hot streams ]
> > >
> > > hot chain pair 1:
> > > cycles: 1, hits: 27.77% cycles: 1, hits: 9.24%
> > > --------------------------- --------------------------
> > > main div.c:39 main div.c:39
> > > main div.c:44 main div.c:44
> > >
> > > hot chain pair 2:
> > > cycles: 34, hits: 20.06% cycles: 27, hits: 16.98%
> > > --------------------------- --------------------------
> > > __random_r random_r.c:360 __random_r random_r.c:360
> >
> > Would it be interesting to get the associated source code and show right below
> > these file:number lines?
> >
> > - Arnaldo
> >
>
> I'm thinking we can implement this function in callchain_list__sym_name(),
> and then all callchain functionality will benefit from it. While that looks
> to be another patchset. :)
Sure, after we go thru the process of merging the current one.
> Thanks
> Jin Yao
--
- Arnaldo
next prev parent reply other threads:[~2020-09-21 12:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 8:03 [PATCH v6 0/7] perf: Stream comparison Jin Yao
2020-09-11 8:03 ` [PATCH v6 1/7] perf util: Create streams Jin Yao
2020-09-17 20:20 ` Arnaldo Carvalho de Melo
2020-09-11 8:03 ` [PATCH v6 2/7] perf util: Get the evsel_streams by evsel_idx Jin Yao
2020-09-17 20:23 ` Arnaldo Carvalho de Melo
2020-09-11 8:03 ` [PATCH v6 3/7] perf util: Compare two streams Jin Yao
2020-09-11 8:03 ` [PATCH v6 4/7] perf util: Link stream pair Jin Yao
2020-09-17 20:23 ` Arnaldo Carvalho de Melo
2020-09-11 8:03 ` [PATCH v6 5/7] perf util: Calculate the sum of total streams hits Jin Yao
2020-09-11 8:03 ` [PATCH v6 6/7] perf util: Report hot streams Jin Yao
2020-09-11 8:03 ` [PATCH v6 7/7] perf diff: Support hot streams comparison Jin Yao
2020-09-17 20:26 ` Arnaldo Carvalho de Melo
2020-09-18 6:58 ` Jin, Yao
2020-09-19 4:41 ` Jin, Yao
2020-09-21 12:17 ` Arnaldo Carvalho de Melo [this message]
2020-09-17 13:05 ` [PATCH v6 0/7] perf: Stream comparison Jiri Olsa
2020-09-17 20:13 ` Arnaldo Carvalho de Melo
2020-09-18 6:54 ` Jin, Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200921121700.GH1996959@kernel.org \
--to=acme@kernel.org \
--cc=Linux-kernel@vger.kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox