From: Kalle Valo <kvalo@codeaurora.org>
To: Huang Guobin <huangguobin4@huawei.com>
Cc: <ajay.kathat@microchip.com>, <claudiu.beznea@microchip.com>,
<davem@davemloft.net>, <kuba@kernel.org>,
<gregkh@linuxfoundation.org>, <linux-wireless@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: wilc1000: clean up resource in error path of init mon interface
Date: Mon, 21 Sep 2020 13:02:28 +0000 (UTC) [thread overview]
Message-ID: <20200921130228.7C1E1C433CB@smtp.codeaurora.org> (raw)
In-Reply-To: <20200917123019.206382-1-huangguobin4@huawei.com>
Huang Guobin <huangguobin4@huawei.com> wrote:
> The wilc_wfi_init_mon_int() forgets to clean up resource when
> register_netdevice() failed. Add the missed call to fix it.
> And the return value of netdev_priv can't be NULL, so remove
> the unnecessary error handling.
>
> Fixes: 588713006ea4 ("staging: wilc1000: avoid the use of 'wilc_wfi_mon' static variable")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Huang Guobin <huangguobin4@huawei.com>
Patch applied to wireless-drivers-next.git, thanks.
55bd14997867 net: wilc1000: clean up resource in error path of init mon interface
--
https://patchwork.kernel.org/patch/11782369/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-09-21 13:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 12:30 [PATCH net] net: wilc1000: clean up resource in error path of init mon interface Huang Guobin
2020-09-21 13:02 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200921130228.7C1E1C433CB@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ajay.kathat@microchip.com \
--cc=claudiu.beznea@microchip.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=huangguobin4@huawei.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox