From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC25DC43466 for ; Mon, 21 Sep 2020 16:31:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 78CA52399C for ; Mon, 21 Sep 2020 16:31:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600705915; bh=sCSX/hkS/jZYAfpuxjYlfWkuz9jej7DqloL+c37m8TY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=SqryAhacaTyrDeeeRh3bdrKa/L+oviH0WW6syYKOEgtKDj5Rpo4RT+176DhElHqz8 LsRY5iOCxW0hpqhQPdcarEFiz5/TMzAP6/HhguseOm2ImJCODFLsJ9XH+z8cz7w3zK XHkxdCH79OSXd/iIcCHdv5oGt0EHToVAIXrYECEU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728306AbgIUQby (ORCPT ); Mon, 21 Sep 2020 12:31:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:56920 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728246AbgIUQbu (ORCPT ); Mon, 21 Sep 2020 12:31:50 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 59408235F9; Mon, 21 Sep 2020 16:31:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600705909; bh=sCSX/hkS/jZYAfpuxjYlfWkuz9jej7DqloL+c37m8TY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kf3URe3/mbPiCcvi/HCA0PO1z7CDV2AcHdP8eFg/ZhhGjb803q76eCT5EWRSg23UX MieuSt6nj8dcuSnAxAi5n95JI/EmKPy8q1cnF2Pz+5jW4ps2DZygaNUEXVh2JU6aNl pDxhc1ikObNHf4/cczcfKgK0MyGtaYuaG4HnK5lo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dinghao Liu , "David S. Miller" , Sasha Levin Subject: [PATCH 4.4 04/46] firestream: Fix memleak in fs_open Date: Mon, 21 Sep 2020 18:27:20 +0200 Message-Id: <20200921162033.560497929@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200921162033.346434578@linuxfoundation.org> References: <20200921162033.346434578@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dinghao Liu [ Upstream commit 15ac5cdafb9202424206dc5bd376437a358963f9 ] When make_rate() fails, vcc should be freed just like other error paths in fs_open(). Signed-off-by: Dinghao Liu Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/atm/firestream.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/atm/firestream.c b/drivers/atm/firestream.c index 04b39d0da8681..70708608ab1e7 100644 --- a/drivers/atm/firestream.c +++ b/drivers/atm/firestream.c @@ -1009,6 +1009,7 @@ static int fs_open(struct atm_vcc *atm_vcc) error = make_rate (pcr, r, &tmc0, NULL); if (error) { kfree(tc); + kfree(vcc); return error; } } -- 2.25.1