From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B924C4727C for ; Tue, 22 Sep 2020 06:41:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 53BDA22574 for ; Tue, 22 Sep 2020 06:41:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600756868; bh=fpjEKO0HEwKVPJVEg6fnVWA4DnHuAPPahJEOFfNsJ+8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=AgbQv2gg1l+Pkoeh1YfW2DjCMZXrDxUHqqbxxPwoSfJRObp3ZZYY/8skHxz4eIxbU 1Kha3Dh4MmQGIffouxFsweACkXD6zhOkBAoV8WqDaLy0CPW489dOttA5R3b1abTUk9 kkhp5w44LYWZL7mNELx/d3Bd0webl8xxNWQ6hho4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729464AbgIVGlH (ORCPT ); Tue, 22 Sep 2020 02:41:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:47220 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729222AbgIVGlG (ORCPT ); Tue, 22 Sep 2020 02:41:06 -0400 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 39915208A9; Tue, 22 Sep 2020 06:41:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600756866; bh=fpjEKO0HEwKVPJVEg6fnVWA4DnHuAPPahJEOFfNsJ+8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YDz5fyaWjfQOOxQBPCsSpHZgxRgTp3lFkibp1h73W9J+tF4HpTSnSdTl9bJZglV15 QRbPkzsPTDR7oVY+STeBfOULnE24qqLWKkzFYPylSv0R+5gJbFwPtZTI4/6GLF0lXj lzgJZbvqm0Uem9hzkyBpix4oXzvRvEw+nVGFpzAc= Date: Tue, 22 Sep 2020 14:40:59 +0800 From: Shawn Guo To: Krzysztof Kozlowski Cc: Rob Herring , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Adam Ford , Daniel Baluta , Anson Huang , Jacky Bai , Robin Gong , Peter Chen , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tim Harvey Subject: Re: [PATCH v2 1/4] ARM: dts: imx6qdl-gw5xxx: correct interrupt flags Message-ID: <20200922064058.GE25109@dragon> References: <20200917185449.5687-1-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200917185449.5687-1-krzk@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 17, 2020 at 08:54:46PM +0200, Krzysztof Kozlowski wrote: > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. > These are simple defines so they could be used in DTS but they will not > have the same meaning: > 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE > 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING > > Correct the interrupt flags, assuming the author of the code wanted same > logical behavior behind the name "ACTIVE_xxx", this is: > ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW > > Signed-off-by: Krzysztof Kozlowski Applied all, thanks.