From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Xianting Tian <tian.xianting@h3c.com>,
axboe@fb.com, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] nvme: replace meaningless judgement by checking whether req is null
Date: Tue, 22 Sep 2020 16:58:42 +0200 [thread overview]
Message-ID: <20200922145842.GB28420@lst.de> (raw)
In-Reply-To: <20200922145705.GA4035426@dhcp-10-100-145-180.wdl.wdc.com>
On Tue, Sep 22, 2020 at 07:57:05AM -0700, Keith Busch wrote:
> The commit subject is a too long. We should really try to keep these to
> 50 characters or less.
>
> nvme-pci: fix NULL req in completion handler
>
> Otherwise, looks fine.
>
> Reviewed-by: Keith Busch <kbusch@kernel.org>
Yes. I was about to apply it with a similar edit, but I'll take yours
happily.
next prev parent reply other threads:[~2020-09-22 14:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 6:25 [PATCH] [v2] nvme: replace meaningless judgement by checking whether req is null Xianting Tian
2020-09-22 14:57 ` Keith Busch
2020-09-22 14:58 ` Christoph Hellwig [this message]
2020-09-22 15:27 ` Tianxianting
2020-09-22 15:41 ` Christoph Hellwig
2020-09-22 15:47 ` Tianxianting
2020-09-23 5:29 ` Christoph Hellwig
2020-09-29 8:14 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922145842.GB28420@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=tian.xianting@h3c.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox