From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Kamel Bouhara <kamel.bouhara@bootlin.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] counter: microchip-tcb-capture: Constify mchp_tc_ops
Date: Tue, 22 Sep 2020 21:48:38 -0400 [thread overview]
Message-ID: <20200923014838.GA3267@shinobu> (raw)
In-Reply-To: <20200922201941.41328-1-rikard.falkeborn@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]
On Tue, Sep 22, 2020 at 10:19:41PM +0200, Rikard Falkeborn wrote:
> The only usage of mchp_tc_ops is to assign its address to the ops field
> in the counter_device struct which is a const pointer. Make it const to
> allow the compiler to put it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com>
> ---
> drivers/counter/microchip-tcb-capture.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c
> index b7b252c5addf..039c54a78aa5 100644
> --- a/drivers/counter/microchip-tcb-capture.c
> +++ b/drivers/counter/microchip-tcb-capture.c
> @@ -253,7 +253,7 @@ static struct counter_count mchp_tc_counts[] = {
> },
> };
>
> -static struct counter_ops mchp_tc_ops = {
> +static const struct counter_ops mchp_tc_ops = {
> .signal_read = mchp_tc_count_signal_read,
> .count_read = mchp_tc_count_read,
> .function_get = mchp_tc_count_function_get,
> --
> 2.28.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-09-23 1:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 20:19 [PATCH] counter: microchip-tcb-capture: Constify mchp_tc_ops Rikard Falkeborn
2020-09-23 1:48 ` William Breathitt Gray [this message]
2020-09-23 19:56 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200923014838.GA3267@shinobu \
--to=vilhelm.gray@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=kamel.bouhara@bootlin.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rikard.falkeborn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox