From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3270BC4727C for ; Wed, 23 Sep 2020 03:45:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB4502193E for ; Wed, 23 Sep 2020 03:45:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726825AbgIWDpY (ORCPT ); Tue, 22 Sep 2020 23:45:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726448AbgIWDpY (ORCPT ); Tue, 22 Sep 2020 23:45:24 -0400 Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [IPv6:2002:c35c:fd02::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D12DAC061755; Tue, 22 Sep 2020 20:45:23 -0700 (PDT) Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKviT-004Gtp-DG; Wed, 23 Sep 2020 03:45:13 +0000 Date: Wed, 23 Sep 2020 04:45:13 +0100 From: Al Viro To: Christoph Hellwig Cc: Anna Schumaker , Trond Myklebust , Richard Henderson , Ivan Kokshaysky , Matt Turner , linux-alpha@vger.kernel.org, Linux Kernel Mailing List , linux-fsdevel , Linux NFS Mailing List Subject: Re: [PATCH 2/5] fs,nfs: lift compat nfs4 mount data handling into the nfs code Message-ID: <20200923034513.GF3421308@ZenIV.linux.org.uk> References: <20200917082236.2518236-1-hch@lst.de> <20200917082236.2518236-3-hch@lst.de> <20200917171604.GW3421308@ZenIV.linux.org.uk> <20200917171826.GA8198@lst.de> <20200921064813.GB18559@lst.de> <20200921181123.GA1776@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200921181123.GA1776@lst.de> Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 21, 2020 at 08:11:23PM +0200, Christoph Hellwig wrote: > On Mon, Sep 21, 2020 at 12:05:52PM -0400, Anna Schumaker wrote: > > This is for the binary mount stuff? That was already legacy code when > > I first started, and mount uses text options now. My preference is for > > keeping it as close to the original code as possible. > > Ok. Al, are you fine with the series as-is then? I can live with that. I'm not fond of in_compat_syscall() proliferation, but in this case it's reasonably sane... OK, applied.