From: Jan Kara <jack@suse.cz>
To: Hui Su <sh_def@163.com>
Cc: tytso@mit.edu, jack@suse.com, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] FIX the comment of struct jbd2_journal_handle
Date: Wed, 23 Sep 2020 12:35:31 +0200 [thread overview]
Message-ID: <20200923103531.GE6719@quack2.suse.cz> (raw)
In-Reply-To: <20200922171231.GA53120@rlk>
On Wed 23-09-20 01:12:31, Hui Su wrote:
> the struct name was modified long ago, but the comment still
> use struct handle_s.
>
> Signed-off-by: Hui Su <sh_def@163.com>
Thanks for the patch. It looks good to me. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> include/linux/jbd2.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
> index 08f904943ab2..a1ef05412acf 100644
> --- a/include/linux/jbd2.h
> +++ b/include/linux/jbd2.h
> @@ -452,8 +452,8 @@ struct jbd2_inode {
> struct jbd2_revoke_table_s;
>
> /**
> - * struct handle_s - The handle_s type is the concrete type associated with
> - * handle_t.
> + * struct jbd2_journal_handle - The jbd2_journal_handle type is the concrete
> + * type associated with handle_t.
> * @h_transaction: Which compound transaction is this update a part of?
> * @h_journal: Which journal handle belongs to - used iff h_reserved set.
> * @h_rsv_handle: Handle reserved for finishing the logical operation.
> --
> 2.25.1
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2020-09-23 10:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 17:12 [PATCH] FIX the comment of struct jbd2_journal_handle Hui Su
2020-09-23 10:35 ` Jan Kara [this message]
2020-10-03 4:59 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200923103531.GE6719@quack2.suse.cz \
--to=jack@suse.cz \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sh_def@163.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox