From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2719C4727E for ; Wed, 23 Sep 2020 21:02:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 79F0920888 for ; Wed, 23 Sep 2020 21:02:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ZWKjzla4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726665AbgIWVCw (ORCPT ); Wed, 23 Sep 2020 17:02:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726572AbgIWVCw (ORCPT ); Wed, 23 Sep 2020 17:02:52 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BE81C0613CE for ; Wed, 23 Sep 2020 14:02:52 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id e4so370257pln.10 for ; Wed, 23 Sep 2020 14:02:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=CUC9K3dEL2hB4V0jU6qeK75cHX30YcxDUaS7J9CEnqw=; b=ZWKjzla4G0Whff6qOnJmf4q4ZgSR4pu+SYJyHD4rChnqXiftmthkZtMCryFYJ+AgKm /P3bITmJAoIv1aDo7J6i59wz2BgytVCxY5BDyZyF5tO12iu5WuxBvdplIhhvXFLmdW6U AwikORFojCAMGSwoGpo7cVAgWVvujGTSvdRU0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CUC9K3dEL2hB4V0jU6qeK75cHX30YcxDUaS7J9CEnqw=; b=SPV+1EqaAOuX8N0nHzpTHFTj3MKtCKElNkC48Zo32mjXcfb/q7TpnchQ9aS0YpOKUQ 05uxF8BNTeyYV6GuXyOjgBnIQAqM3R+cCb3HIEIZVq7m6JP6wwn/yNONboNSluRkCMZ4 G7Ge1h2PjkothMxplrho0+xUq+GVcz6hNSGjIryTk5kkVf1iCQ4ypGH6Nk+lzft9gzid rmSaH/iXT4LDByCSQ4u8FO6eA9UIoibpp0WAiMx5psaauzbUYyqG6Ny/toMqhrYu1gZ7 Go+r4Y23P41LbtiObFhappaEir5sa2DfjLq+i83A6lGLzND0/bgZn+Ue7GJ+h3HoWO5r GOSA== X-Gm-Message-State: AOAM5337anijIuc+j+xWipm6RJnd/yjccFg0Ezemh5Fu8y44euXrRQfq +akb1M59Bc3MciCSOWAdV2xW4Q== X-Google-Smtp-Source: ABdhPJz6YlD1PTJXLmB5RxC4afNF/67V7gCRw8d5CRd7/y/DXsELp3q9+x7e/mU97/M4umQHW8P3Cg== X-Received: by 2002:a17:90b:1812:: with SMTP id lw18mr994545pjb.133.1600894971623; Wed, 23 Sep 2020 14:02:51 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id u15sm534468pfm.61.2020.09.23.14.02.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Sep 2020 14:02:50 -0700 (PDT) Date: Wed, 23 Sep 2020 14:02:49 -0700 From: Kees Cook To: Ard Biesheuvel Cc: Linux Kernel Mailing List , linux-efi , Matthew Garrett , Peter Jones , Anton Vorontsov , Colin Cross , Tony Luck Subject: Re: [PATCH 1/7] efi: pstore: disentangle from deprecated efivars module Message-ID: <202009231400.E52D1C7E7@keescook> References: <20200923161404.17811-1-ardb@kernel.org> <20200923161404.17811-2-ardb@kernel.org> <202009231140.B4648C6@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 23, 2020 at 08:43:21PM +0200, Ard Biesheuvel wrote: > On Wed, 23 Sep 2020 at 20:41, Kees Cook wrote: > > > > On Wed, Sep 23, 2020 at 06:13:58PM +0200, Ard Biesheuvel wrote: > > > The EFI pstore implementation relies on the 'efivars' abstraction, > > > which encapsulates the EFI variable store in a way that can be > > > overridden by other backing stores, like the Google SMI one. > > > > > > On top of that, the EFI pstore implementation also relies on the > > > efivars.ko module, which is a separate layer built on top of the > > > 'efivars' abstraction that exposes the [deprecated] sysfs entries > > > for each variable that exists in the backing store. > > > > > > Since the efivars.ko module is deprecated, and all users appear to > > > have moved to the efivarfs file system instead, let's prepare for > > > its removal, by removing EFI pstore's dependency on it. > > > > > > Signed-off-by: Ard Biesheuvel > > > > With this and the other pstore patch, do the pstore self-tests still > > pass on an EFI system? > > > > If so, please consider both: > > > > Acked-by: Kees Cook > > > > Selftests? Excellent! Are they documented too? Not really, but they're pretty simple: cd tools/testing/selftests/pstore *double-check "config" against running kernel config* ./pstore_tests ./pstore_crash_test *wait for system to reboot* cd tools/testing/selftests/pstore ./pstore_post_reboot_tests (though please test before/after, just to make sure other deltas haven't broken things before your series -- I don't test EFI pstore with high frequency) -- Kees Cook