From: "Marek Behún" <kabel@kernel.org>
To: Dan Murphy <dmurphy@ti.com>
Cc: <pavel@ucw.cz>, <linux-leds@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] leds: lm36274: Fix warning for undefined parameters
Date: Wed, 23 Sep 2020 15:10:40 +0200 [thread overview]
Message-ID: <20200923151040.2237af86@kernel.org> (raw)
In-Reply-To: <20200922190638.5323-2-dmurphy@ti.com>
On Tue, 22 Sep 2020 14:06:38 -0500
Dan Murphy <dmurphy@ti.com> wrote:
> Fix warnings for undefined parameters when building with W=1.
>
> Fixes: 11e1bbc116a75 ("leds: lm36274: Introduce the TI LM36274 LED driver")
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> drivers/leds/leds-lm36274.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/leds-lm36274.c b/drivers/leds/leds-lm36274.c
> index 10a63b7f2ecc..bf6487e9a1f4 100644
> --- a/drivers/leds/leds-lm36274.c
> +++ b/drivers/leds/leds-lm36274.c
> @@ -26,8 +26,8 @@
> * @lmu_data: Register and setting values for common code
> * @regmap: Devices register map
> * @dev: Pointer to the devices device struct
> - * @led_sources - The LED strings supported in this array
> - * @num_leds - Number of LED strings are supported in this array
> + * @led_sources: The LED strings supported in this array
> + * @num_leds: Number of LED strings are supported in this array
> */
> struct lm36274 {
> struct platform_device *pdev;
> @@ -163,6 +163,7 @@ static struct platform_driver lm36274_driver = {
> .probe = lm36274_probe,
> .driver = {
> .name = "lm36274-leds",
> + .of_match_table = of_lm36274_leds_match,
> },
> };
> module_platform_driver(lm36274_driver)
Reviewed-by: Marek Behún <kabel@kernel.org>
next prev parent reply other threads:[~2020-09-23 13:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 19:06 [PATCH 1/2] leds: lm3552: Fix warnings for undefined parameters Dan Murphy
2020-09-22 19:06 ` [PATCH 2/2] leds: lm36274: Fix warning " Dan Murphy
2020-09-23 13:10 ` Marek Behún [this message]
2020-09-24 12:19 ` Pavel Machek
2020-09-23 13:14 ` [PATCH 1/2] leds: lm3552: Fix warnings " Marek Behun
2020-09-24 12:20 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200923151040.2237af86@kernel.org \
--to=kabel@kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox