From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E931C2D0E2 for ; Wed, 23 Sep 2020 13:10:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 48E98221E7 for ; Wed, 23 Sep 2020 13:10:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600866646; bh=gPdtthN3zIEZHEiesBpvqVcc10/UOJSsYkiCJAIbYLs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=nGp7pGC/1Gvtb5n1hRfEjIkfOGu3UIJ1D7o/4UMPqx7kIAqytA59m41opEvbT3WrL IqjWjeoQwAA4ceRWxSG0L7dN59M1Y0f7YJ25/p4Z7JZnfR7xuXtVQUpTtkCqXmKHBg U7QGEh++vo7N3K1nj/npKzwU57OAIYG/6s/EFudY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726594AbgIWNKp (ORCPT ); Wed, 23 Sep 2020 09:10:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:57732 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726476AbgIWNKo (ORCPT ); Wed, 23 Sep 2020 09:10:44 -0400 Received: from localhost (otava-0257.koleje.cuni.cz [78.128.181.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3BFA421BE5; Wed, 23 Sep 2020 13:10:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600866644; bh=gPdtthN3zIEZHEiesBpvqVcc10/UOJSsYkiCJAIbYLs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Wzm1zYP9v2PTIk7Xs9sw/0GVCkbSwfBwhRlLIuHi+HBgikqBuq26zK7SrTKu0BCgR zftdOlt/JBusm9XIZVx4DQ769ne4sJ0bIpjrpuFhVLVAHHnC3Ucnk3ktBvq8vzCRhp tIQGVGdp90kVMM3bUwp2QAo/FG5fwUQo/a5Sjpy0= Date: Wed, 23 Sep 2020 15:10:40 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Dan Murphy Cc: , , Subject: Re: [PATCH 2/2] leds: lm36274: Fix warning for undefined parameters Message-ID: <20200923151040.2237af86@kernel.org> In-Reply-To: <20200922190638.5323-2-dmurphy@ti.com> References: <20200922190638.5323-1-dmurphy@ti.com> <20200922190638.5323-2-dmurphy@ti.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 22 Sep 2020 14:06:38 -0500 Dan Murphy wrote: > Fix warnings for undefined parameters when building with W=3D1. >=20 > Fixes: 11e1bbc116a75 ("leds: lm36274: Introduce the TI LM36274 LED driver= ") > Signed-off-by: Dan Murphy > --- > drivers/leds/leds-lm36274.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/leds/leds-lm36274.c b/drivers/leds/leds-lm36274.c > index 10a63b7f2ecc..bf6487e9a1f4 100644 > --- a/drivers/leds/leds-lm36274.c > +++ b/drivers/leds/leds-lm36274.c > @@ -26,8 +26,8 @@ > * @lmu_data: Register and setting values for common code > * @regmap: Devices register map > * @dev: Pointer to the devices device struct > - * @led_sources - The LED strings supported in this array > - * @num_leds - Number of LED strings are supported in this array > + * @led_sources: The LED strings supported in this array > + * @num_leds: Number of LED strings are supported in this array > */ > struct lm36274 { > struct platform_device *pdev; > @@ -163,6 +163,7 @@ static struct platform_driver lm36274_driver =3D { > .probe =3D lm36274_probe, > .driver =3D { > .name =3D "lm36274-leds", > + .of_match_table =3D of_lm36274_leds_match, > }, > }; > module_platform_driver(lm36274_driver) Reviewed-by: Marek Beh=C3=BAn