From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00987C2D0A8 for ; Wed, 23 Sep 2020 19:17:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ADD9920BED for ; Wed, 23 Sep 2020 19:17:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726749AbgIWTRj (ORCPT ); Wed, 23 Sep 2020 15:17:39 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:51750 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726199AbgIWTRj (ORCPT ); Wed, 23 Sep 2020 15:17:39 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kLAGj-00FvC2-Ls; Wed, 23 Sep 2020 21:17:33 +0200 Date: Wed, 23 Sep 2020 21:17:33 +0200 From: Andrew Lunn To: Stefan Riedmueller Cc: Fugang Duan , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Hemp , Jakub Kicinski , "David S . Miller" , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] net: fec: Keep device numbering consistent with datasheet Message-ID: <20200923191733.GD3764123@lunn.ch> References: <20200923142528.303730-1-s.riedmueller@phytec.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200923142528.303730-1-s.riedmueller@phytec.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 23, 2020 at 04:25:28PM +0200, Stefan Riedmueller wrote: > From: Christian Hemp > > Make use of device tree alias for device enumeration to keep the device > order consistent with the naming in the datasheet. > > Otherwise for the i.MX 6UL/ULL the ENET1 interface is enumerated as eth1 > and ENET2 as eth0. What is wrong with that? Ethernet interface names have never been guaranteed to be stable. You have to be careful here. Have you reviewed all the DTS files to make sure none already have aliases? You could be breaking boards which currently 'work' because the alias is ignored. udev is actually a better solution for giving the interfaces dependable names. Andrew