From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 601D7C4346E for ; Thu, 24 Sep 2020 08:26:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0EB28221EB for ; Thu, 24 Sep 2020 08:26:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727277AbgIXI05 (ORCPT ); Thu, 24 Sep 2020 04:26:57 -0400 Received: from verein.lst.de ([213.95.11.211]:51414 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727031AbgIXI04 (ORCPT ); Thu, 24 Sep 2020 04:26:56 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id E20A468AFE; Thu, 24 Sep 2020 10:26:52 +0200 (CEST) Date: Thu, 24 Sep 2020 10:26:52 +0200 From: Christoph Hellwig To: Dan Carpenter Cc: Andrew Morton , Christoph Hellwig , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , Chris Wilson , Matthew Auld , Abdiel Janulgue , Dave Airlie , Stephen Rothwell , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] drm/i915: Uninitialized variable in i915_gem_object_map_page() Message-ID: <20200924082652.GA14084@lst.de> References: <20200924081830.GA1568157@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200924081830.GA1568157@mwanda> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 24, 2020 at 11:18:30AM +0300, Dan Carpenter wrote: > The "i" iterator is never set to zero. This probably doesn't affect > testing because GCC sometimes initializes variables and also we have a > new pluggin to initialize stack variables to zero. > > Fixes: 7edd32a9e614 ("drm/i915: use vmap in i915_gem_object_map") > Signed-off-by: Dan Carpenter > --- > Hi Andrew, this should probably go through the -mm tree and get folded > into the original patch. FYI, I'll need to resend anyway, and I've folded this into the latest branch.