From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 393B8C4346E for ; Thu, 24 Sep 2020 08:48:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F155B23787 for ; Thu, 24 Sep 2020 08:48:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727268AbgIXIsw (ORCPT ); Thu, 24 Sep 2020 04:48:52 -0400 Received: from 8bytes.org ([81.169.241.247]:46202 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726710AbgIXIsw (ORCPT ); Thu, 24 Sep 2020 04:48:52 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id 5200C295; Thu, 24 Sep 2020 10:48:50 +0200 (CEST) Date: Thu, 24 Sep 2020 10:48:48 +0200 From: Joerg Roedel To: Marek Szyprowski Cc: Yu Kuai , kgene@kernel.org, krzk@kernel.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com Subject: Re: [PATCH] iommu/exynos: add missing put_device() call in exynos_iommu_of_xlate() Message-ID: <20200924084848.GD27174@8bytes.org> References: <20200918011335.909141-1-yukuai3@huawei.com> <9f5b25ee-3dad-1798-fe55-9c1af9cde513@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9f5b25ee-3dad-1798-fe55-9c1af9cde513@samsung.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 18, 2020 at 05:27:59PM +0200, Marek Szyprowski wrote: > Hi > > On 18.09.2020 03:13, Yu Kuai wrote: > > if of_find_device_by_node() succeed, exynos_iommu_of_xlate() doesn't have > > a corresponding put_device(). Thus add put_device() to fix the exception > > handling for this function implementation. > > > > Fixes: aa759fd376fb ("iommu/exynos: Add callback for initializing devices from device tree") > > Signed-off-by: Yu Kuai > > Thanks for the fix! > > Acked-by: Marek Szyprowski Applied for v5.9, thanks.