From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8878EC4363D for ; Thu, 24 Sep 2020 12:40:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 486C5206D9 for ; Thu, 24 Sep 2020 12:40:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Whtw4ysU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727845AbgIXMkf (ORCPT ); Thu, 24 Sep 2020 08:40:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727570AbgIXMke (ORCPT ); Thu, 24 Sep 2020 08:40:34 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4723FC0613CE for ; Thu, 24 Sep 2020 05:40:34 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id z1so3664382wrt.3 for ; Thu, 24 Sep 2020 05:40:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=b2lDPvNgcW90ATPJ0W6Cm5nzCR7vWtrpBfUZKLwoBYE=; b=Whtw4ysULiBOjxfFnqdE6kgGRcEheRG7g1Ju/zSoLoYcs/WE74gfKpw4OHU7h3seU7 nz6swSb5eDQ7L9bgCwxZJ2eWUmNIGgLBn/SU9k56Zx8rv2iQDJOQI4M0iLY+mDF0Wa2+ PYweCxZtwn18ZAcsAqO+iZzxo69cAX2Wr/orsbNrXYxufMlOQqlcRt4UYe1bcbGPsrEQ hQ2hU5xQaxp4SCezw91qP5usR+IE532hKc2MSm6VVq3ulWtV3lJsoGaqHAJfGXPiB+AJ buIuBw3pmtbY8odVSk3sqZ6tMj+c+ENivH3ebV8HWFPuH4GEiDBoAB563DtMSCkjCILU oIIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=b2lDPvNgcW90ATPJ0W6Cm5nzCR7vWtrpBfUZKLwoBYE=; b=bDYZy81dgALsMk8K02ATrPj0ca4aUvw4y1S0vEfivdFqpRA/IqvV8+DA/3RhBzYxCJ IBHPFo06r3v7boVTIXauuC+M30K4RTKt4hj8kOfAYPtBcxF/hfLgBVeuzn1C6MW307IQ aNQqxDRQvZ7lo3iZ7QyNEar7doAkWd+fE+n3hNDB3CgPhftR6YveIw7j67MJ8n44Pnhd byF4YXmVe/A4+ADICGaWFYEieC6TuylWJZ7ys9g9duWM1THC8j1WAXFMHy1lt94a1gQG N9eGkv2ahFV01zXDxDxkWwuUCqTQPS0sBSDkPLHkOpgEBtrp7S0Bfkb+fzlnpjPfoHEB JNyQ== X-Gm-Message-State: AOAM530Ni/GiOfGWKDle22Dg1fquuYS4Z68oXvtrO4YI4cFHZ1Z4ZBwy PunnAKozKic2EBidjsCuz3N5aQ== X-Google-Smtp-Source: ABdhPJy5etVAKJBI8BzMQLjxLKwC8dcLGsYrTzKTEFk+k5Pr3/2wNCCUe6bHw+q1Fuv9x8rNwEvhig== X-Received: by 2002:a5d:4744:: with SMTP id o4mr4883028wrs.130.1600951233003; Thu, 24 Sep 2020 05:40:33 -0700 (PDT) Received: from dell ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f16sm3466734wrp.47.2020.09.24.05.40.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2020 05:40:32 -0700 (PDT) Date: Thu, 24 Sep 2020 13:40:30 +0100 From: Lee Jones To: Dan Carpenter Cc: Ben Dooks , Andrew Morton , Vincent Sanders , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mfd: sm501: Fix leaks in probe() Message-ID: <20200924124030.GK4678@dell> References: <20200911113326.GB367487@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200911113326.GB367487@mwanda> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 11 Sep 2020, Dan Carpenter wrote: > This code should clean up if sm501_init_dev() fails. > > Fixes: b6d6454fdb66 ("[PATCH] mfd: SM501 core driver") > Signed-off-by: Dan Carpenter > --- > drivers/mfd/sm501.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog