From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6911DC4727D for ; Thu, 24 Sep 2020 13:34:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C04B23787 for ; Thu, 24 Sep 2020 13:34:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="wWMf+nQe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728003AbgIXNew (ORCPT ); Thu, 24 Sep 2020 09:34:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727742AbgIXNev (ORCPT ); Thu, 24 Sep 2020 09:34:51 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EB22C0613D3 for ; Thu, 24 Sep 2020 06:34:51 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id c18so3819573wrm.9 for ; Thu, 24 Sep 2020 06:34:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=AHmQxIHTPufi+UR2RfGLNgHO/eGPtc+JmSaoagltYVc=; b=wWMf+nQe5B/34hqIN8sqpervlaXL5/2jAPnWv88YCj6AJTvL9Viemp26b9S/QzgjJT Kvn0I9+JfmDm7IvImZnITMdUtGXfvGsZv2gBPwDhzaXG2bUGvPWjyCQwN0sYWdJu57IX ViFp2j1SODpDHoK2ZMPTh6/j229FaCU9pHDQBdjdytT+Eo1dFyqwKKl0WXdelRTT6f1J x5Hs8COVRdDhy1UQwpQ+0itqy9Cj6GBMRZHLHWSJWuyoAEToYU5lm4OVDCZb+HPvJ+n1 1A7qBk0UVwrsz9a3Ci56pRhlnuCLuVtG0gNbu4se+m2dhLTI/GO4IC/PAkIRIOIR6WxK QQ4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AHmQxIHTPufi+UR2RfGLNgHO/eGPtc+JmSaoagltYVc=; b=QupbyQIBBkzTb1L9oXf/AH8dKdr7HaFxUGKjZGVIhh/O4ir+CVchGpWc5iixydpWRK fYnFW5c112EZVvdBJWBGEBM5hJwCqsK2b2WqRvhvGGFbzm56h44F2YLi6jZnR/dJHKkd sMihk1V8LJz8tw4oPny0C9Pdx0ak00E1bDiET6Wo/iHCHgaCuN5vkaNYYeGdF7R01snO a4TkP22gpMcYAMgx5v35LX5uLiMLn+kWdczQht3d4RWY1jNZJwYK0DYes2309WOfmIl7 GixfguT7yJGg/GC6fbcagu6NVUXRVFubnHIzpdwKHiZdR/tKiAbkIgiWpbF0rcZkKtPQ FAow== X-Gm-Message-State: AOAM533etQC0kdewqFRM2cmfoVgVzdI9jP342eTDvarp+DS4180LRrqF bcrAiXLe2dAWjLyZe61pZzr5wg== X-Google-Smtp-Source: ABdhPJzz1iuxB8yMgk8VfJVBob6+7W+AlkLoqZKC4tAXB33eouYnScSHMBpBmeoACCVJjNkW7/U/eg== X-Received: by 2002:adf:f986:: with SMTP id f6mr4949309wrr.270.1600954490182; Thu, 24 Sep 2020 06:34:50 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:f693:9fff:fef4:a7ef]) by smtp.gmail.com with ESMTPSA id j26sm4411495wrc.79.2020.09.24.06.34.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2020 06:34:49 -0700 (PDT) Date: Thu, 24 Sep 2020 14:34:46 +0100 From: Quentin Perret To: Ionela Voinescu Cc: mingo@redhat.com, peterz@infradead.org, vincent.guittot@linaro.org, catalin.marinas@arm.com, will@kernel.org, rjw@rjwysocki.net, viresh.kumar@linaro.org, dietmar.eggemann@arm.com, valentin.schneider@arm.com, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] sched/topology,schedutil: wrap sched domains rebuild Message-ID: <20200924133446.GA3920949@google.com> References: <20200924123937.20938-1-ionela.voinescu@arm.com> <20200924123937.20938-2-ionela.voinescu@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200924123937.20938-2-ionela.voinescu@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 24 Sep 2020 at 13:39:35 (+0100), Ionela Voinescu wrote: > @@ -433,6 +437,7 @@ static bool build_perf_domains(const struct cpumask *cpu_map) > } > #else > static void free_pd(struct perf_domain *pd) { } > +void rebuild_sched_domains_energy(void) { } Nit: maybe make that stub static inline in a header instead? I guess LTO and friends ought to clean that up for you, but it shouldn't hurt to give the compiler a little bit of help here. Otherwise, LGTM: Acked-by: Quentin Perret > #endif /* CONFIG_ENERGY_MODEL && CONFIG_CPU_FREQ_GOV_SCHEDUTIL*/ > > static void free_rootdomain(struct rcu_head *rcu) > -- > 2.17.1 >