Re: [PATCH 07/13] block: lift setting the readahead size into the block layer

Martin K. Petersen
2020-09-24T15:57:51Z

Christoph,

> Drivers shouldn't really mess with the readahead size, as that is a VM
> concept. Instead set it based on the optimal I/O size by lifting the
> algorithm from the md driver when registering the disk. Also set
> bdi->io_pages there as well by applying the same scheme based on
> max_sectors. To ensure the limits work well for stacking drivers a
> new helper is added to update the readahead limits from the block
> limits, which is also called from disk_stack_limits.

Looks good!

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

--
Martin K. Petersen Oracle Linux Engineering