From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 197ADC4727F for ; Fri, 25 Sep 2020 07:51:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0D912084C for ; Fri, 25 Sep 2020 07:51:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="KyNDgmBc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727591AbgIYHvN (ORCPT ); Fri, 25 Sep 2020 03:51:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727068AbgIYHvN (ORCPT ); Fri, 25 Sep 2020 03:51:13 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2153DC0613CE; Fri, 25 Sep 2020 00:51:13 -0700 (PDT) Received: from zn.tnic (p200300ec2f0b3a00d3756fc4b2470eaa.dip0.t-ipconnect.de [IPv6:2003:ec:2f0b:3a00:d375:6fc4:b247:eaa]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id A494B1EC0430; Fri, 25 Sep 2020 09:51:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1601020271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=11+dIJIDWsv9Zmwi47xIt/rSGrfD4jLF7wfjT5CA6jM=; b=KyNDgmBc0z3FncZjzextI094HFVFRr2mggIQ84SJ9qwTxE0e14C7/l3srzWAe4X/lQq0vj IorTTvTDkX1amBHxVNA16X11tGaUWEPm6VQhI5znh5QcDvPS+FIcna4KvsvFKFZDzFd30i e4XdAM42bVpFg0aIZ2Iwng8tvB86chM= Date: Fri, 25 Sep 2020 09:51:04 +0200 From: Borislav Petkov To: Jarkko Sakkinen Cc: x86@kernel.org, linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org, Jethro Beekman , akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com, asapek@google.com, cedric.xing@intel.com, chenalexchen@google.com, conradparker@google.com, cyhanish@google.com, dave.hansen@intel.com, haitao.huang@intel.com, josh@joshtriplett.org, kai.huang@intel.com, kai.svahn@intel.com, kmoy@google.com, ludloff@google.com, luto@kernel.org, nhorman@redhat.com, npmccallum@redhat.com, puiterwijk@redhat.com, rientjes@google.com, sean.j.christopherson@intel.com, tglx@linutronix.de, yaozhangx@google.com Subject: Re: [PATCH v38 17/24] x86/sgx: ptrace() support for the SGX driver' Message-ID: <20200925075104.GD16872@zn.tnic> References: <20200915112842.897265-1-jarkko.sakkinen@linux.intel.com> <20200915112842.897265-18-jarkko.sakkinen@linux.intel.com> <20200922154424.GL22660@zn.tnic> <20200923132037.GA5160@linux.intel.com> <20200923161733.GP28545@zn.tnic> <20200924115119.GD56811@linux.intel.com> <20200924155751.GJ5030@zn.tnic> <20200924203859.GD108958@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200924203859.GD108958@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 24, 2020 at 11:38:59PM +0300, Jarkko Sakkinen wrote: > I assume this is a rethorical question Of course - our text should not be write-only. > and I notice what I suggested > looks as bad as my earlier commit message :-) > > So, I gave it some thought that and decided to "open code" the paragraph > as > > "Add sgx_vma_access() function that implements 'access' virtual function > of struct vm_operations_struct. Use formentioned leaf instructions to "aforementioned" > achieve read and write primitives for the enclave memory." I'd say "to provide read and write access to enclave memory." -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette