From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50ADAC4363D for ; Fri, 25 Sep 2020 11:47:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 19A0421775 for ; Fri, 25 Sep 2020 11:47:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728147AbgIYLrJ (ORCPT ); Fri, 25 Sep 2020 07:47:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:51308 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727132AbgIYLrJ (ORCPT ); Fri, 25 Sep 2020 07:47:09 -0400 Received: from gaia (unknown [31.124.44.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A4A792083B; Fri, 25 Sep 2020 11:47:06 +0000 (UTC) Date: Fri, 25 Sep 2020 12:47:04 +0100 From: Catalin Marinas To: Andrey Konovalov Cc: Dmitry Vyukov , Vincenzo Frascino , kasan-dev , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , Linux ARM , Linux Memory Management List , LKML Subject: Re: [PATCH v3 26/39] arm64: mte: Add in-kernel tag fault handler Message-ID: <20200925114703.GI4846@gaia> References: <17ec8af55dc0a4d3ade679feb0858f0df4c80d27.1600987622.git.andreyknvl@google.com> <20200925104933.GD4846@gaia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 25, 2020 at 01:26:02PM +0200, Andrey Konovalov wrote: > On Fri, Sep 25, 2020 at 12:49 PM Catalin Marinas > wrote: > > > diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c > > > index a3bd189602df..d110f382dacf 100644 > > > --- a/arch/arm64/mm/fault.c > > > +++ b/arch/arm64/mm/fault.c > > > @@ -33,6 +33,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > #include > > > #include > > > #include > > > @@ -294,6 +295,11 @@ static void die_kernel_fault(const char *msg, unsigned long addr, > > > do_exit(SIGKILL); > > > } > > > > > > +static void report_tag_fault(unsigned long addr, unsigned int esr, > > > + struct pt_regs *regs) > > > +{ > > > +} > > > > Do we need to introduce report_tag_fault() in this patch? It's fine but > > add a note in the commit log that it will be populated in a subsequent > > patch. > > I did, see the last line of the commit description. Sorry, I missed that. > > > + > > > static void __do_kernel_fault(unsigned long addr, unsigned int esr, > > > struct pt_regs *regs) > > > { > > > @@ -641,10 +647,40 @@ static int do_sea(unsigned long addr, unsigned int esr, struct pt_regs *regs) > > > return 0; > > > } > > > > > > +static void do_tag_recovery(unsigned long addr, unsigned int esr, > > > + struct pt_regs *regs) > > > +{ > > > + static bool reported = false; > > > + > > > + if (!READ_ONCE(reported)) { > > > + report_tag_fault(addr, esr, regs); > > > + WRITE_ONCE(reported, true); > > > + } > > > > I don't mind the READ_ONCE/WRITE_ONCE here but not sure what they help > > with. > > The fault can happen on multiple cores at the same time, right? In > that case without READ/WRITE_ONCE() we'll have a data-race here. READ/WRITE_ONCE won't magically solve such races. If two CPUs enter simultaneously in do_tag_recovery(), they'd both read 'reported' as false and both print the fault info. If you really care about this race, you need to atomically both read and update the variable with an xchg() or cmpxchg(). -- Catalin