From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Stephane Eranian <eranian@google.com>,
Andi Kleen <ak@linux.intel.com>, Ian Rogers <irogers@google.com>,
John Garry <john.garry@huawei.com>,
Kajol Jain <kjain@linux.ibm.com>,
kernel test robot <rong.a.chen@intel.com>
Subject: Re: [PATCH 3/5] perf tools: Copy metric events properly when expand cgroups
Date: Fri, 25 Sep 2020 15:26:36 +0200 [thread overview]
Message-ID: <20200925132636.GB3273770@krava> (raw)
In-Reply-To: <20200924124455.336326-4-namhyung@kernel.org>
On Thu, Sep 24, 2020 at 09:44:53PM +0900, Namhyung Kim wrote:
SNIP
>
> + if (metric_events) {
> + orig_metric_events = *metric_events;
> + rblist__init(metric_events);
> + } else {
> + rblist__init(&orig_metric_events);
> + }
> +
> for (;;) {
> p = strchr(str, ',');
> e = p ? p : eos;
> @@ -255,6 +267,14 @@ int evlist__expand_cgroup(struct evlist *evlist, const char *str)
> cgroup__put(cgrp);
> nr_cgroups++;
>
> + if (metric_events) {
> + perf_stat__collect_metric_expr(tmp_list);
> + if (metricgroup__copy_metric_events(tmp_list, cgrp,
> + metric_events,
> + &orig_metric_events) < 0)
> + break;
> + }
looks good, do you plan to actualy add support for record?
my ack from last version stays
thanks,
jirka
next prev parent reply other threads:[~2020-09-25 13:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 12:44 [PATCHSET v5 0/5] perf stat: Expand events for each cgroup Namhyung Kim
2020-09-24 12:44 ` [PATCH 1/5] perf evsel: Add evsel__clone() function Namhyung Kim
2020-09-24 12:44 ` [PATCH 2/5] perf stat: Add --for-each-cgroup option Namhyung Kim
2020-09-24 12:44 ` [PATCH 3/5] perf tools: Copy metric events properly when expand cgroups Namhyung Kim
2020-09-25 13:26 ` Jiri Olsa [this message]
2020-09-25 13:44 ` Namhyung Kim
2020-09-25 13:51 ` Jiri Olsa
2020-09-28 11:54 ` Arnaldo Carvalho de Melo
2020-09-28 12:36 ` Jiri Olsa
2020-09-28 12:17 ` Arnaldo Carvalho de Melo
2020-09-24 12:44 ` [PATCH 4/5] perf tools: Allow creation of cgroup without open Namhyung Kim
2020-09-24 12:44 ` [PATCH 5/5] perf test: Add expand cgroup event test Namhyung Kim
-- strict thread matches above, loose matches on Subject: below --
2020-09-23 1:59 [PATCHSET v4 0/5] perf stat: Expand events for each cgroup Namhyung Kim
2020-09-23 1:59 ` [PATCH 3/5] perf tools: Copy metric events properly when expand cgroups Namhyung Kim
2020-09-23 10:22 ` Jiri Olsa
2020-09-24 3:12 ` Namhyung Kim
2020-09-21 9:46 [PATCHSET v3 0/5] perf stat: Expand events for each cgroup Namhyung Kim
2020-09-21 9:46 ` [PATCH 3/5] perf tools: Copy metric events properly when expand cgroups Namhyung Kim
2020-09-22 21:29 ` Jiri Olsa
2020-09-22 22:46 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925132636.GB3273770@krava \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=john.garry@huawei.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=rong.a.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox