From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3415C4727F for ; Fri, 25 Sep 2020 21:16:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99CDE21D42 for ; Fri, 25 Sep 2020 21:16:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="lS6mzYDj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728051AbgIYVQS (ORCPT ); Fri, 25 Sep 2020 17:16:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727078AbgIYVQR (ORCPT ); Fri, 25 Sep 2020 17:16:17 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F52FC0613CE for ; Fri, 25 Sep 2020 14:16:16 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id n14so4445039pff.6 for ; Fri, 25 Sep 2020 14:16:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=55PyWr34biEDbu3JvsEj0XeSgK/s1KifuEokrJ9uw8o=; b=lS6mzYDjeglwZ8LWkDF3qED4EEy6wjt639vGroQNcpNQrXxqFxslT+7xWwYz3b9zmb CzA8uYWsfAH4cTnNEY7rWVaWrVZNbmzdvVuNTYqHjpZBe7iUpsG6l48Mjq8JHCibxhX3 4rYEPjFkMATB3t6F17GXOaCrf3vG+S1VMrQ9g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=55PyWr34biEDbu3JvsEj0XeSgK/s1KifuEokrJ9uw8o=; b=B57iRBmluyRk8Dx/Tz/6469MOh7Y+/4F5g+FPdlfxDekY3mk9JZSmETSz2KNgfg+bf hJ4iVhWDKKQX9xV9f865O0hQTiOQU/41dyo7ETBT/HfeEUxrfoF+/Z38q9V9NWgap7Uc gqEH0+Z1wbwUb8Day819XWBHelkCifdvPFFfoF1gdO6k7tM3wSBMUiqI+JLk6OOyl/Sx y3NqF8UjHXSV3nvGgOgg1f7tYFOiU0Ue/cEOIz9YTvXTrt+n7E7FhctKfbFKNaeT9Wcs 2N5qZOmg1VhBFcgQJ1bJXzWjiR5TlEDmdYOx4+IheXG+nyCC8xsvS1+ItUEVr64p0sou SaLw== X-Gm-Message-State: AOAM533xZt79RDA1dbfOYeIfkKOpZnqwbXOmIqe/HyB8yc9jZvzkRCQD 4NE/l+8d0kOCRd8Ssaw4dA4zcg== X-Google-Smtp-Source: ABdhPJyjkD1skWphhKbK4Dcb7IHRhoIlmCbnIkoXbgrDslWFDxFt21/1MBLctYp4VAG7P337QhGxxw== X-Received: by 2002:aa7:96bb:0:b029:142:440c:6ebc with SMTP id g27-20020aa796bb0000b0290142440c6ebcmr458230pfk.22.1601068575877; Fri, 25 Sep 2020 14:16:15 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id e19sm3761025pfl.135.2020.09.25.14.16.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2020 14:16:15 -0700 (PDT) Date: Fri, 25 Sep 2020 14:16:14 -0700 From: Kees Cook To: Shuah Khan Cc: Hangbin Liu , "open list:KERNEL SELFTEST FRAMEWORK" , Jonathan Corbet , Naresh Kamboju , linux-doc@vger.kernel.org, open list , Tim.Bird@sony.com, lkft-triage@lists.linaro.org, Anders Roxell , Justin Cook , Linux-Next Mailing List Subject: Re: [PATCHv5 kselftest next] selftests/run_kselftest.sh: make each test individually selectable Message-ID: <202009251414.15274C0@keescook> References: <20200914021758.420874-1-liuhangbin@gmail.com/> <20200914022227.437143-1-liuhangbin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 25, 2020 at 01:51:53PM +0530, Naresh Kamboju wrote: > On Mon, 14 Sep 2020 at 07:53, Hangbin Liu wrote: > > > > Currently, after generating run_kselftest.sh, there is no way to choose > > which test we could run. All the tests are listed together and we have > > to run all every time. This patch enhanced the run_kselftest.sh to make > > the tests individually selectable. e.g. > > > > $ ./run_kselftest.sh -t "bpf size timers" > > My test run break on linux next > > ./run_kselftest.sh: line 1331: syntax error near unexpected token `)' > ./run_kselftest.sh: line 1331: `-e -s | --summary ) > logfile=$BASE_DIR/output.log; cat /dev/null > $logfile; shift ;;' Yes, please revert this patch. The resulting script is completely trashed: BASE_DIR=$(realpath $(dirname $0)) . ./kselftest/runner.sh TESTS="seccomp" run_seccomp() { -e [ -w /dev/kmsg ] && echo "kselftest: Running tests in seccomp" >> /dev/kmsg -e cd seccomp -en run_many \ -ne "seccomp_bpf" \ -ne "seccomp_benchmark" -e cd $ROOT } -- Kees Cook