From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Liu Shixin <liushixin2@huawei.com>
Cc: Stanimir Varbanov <stanimir.varbanov@linaro.org>,
Andy Gross <agross@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] media: venus: simplify the return expression of venus_sys_set_* function
Date: Fri, 25 Sep 2020 10:06:05 -0500 [thread overview]
Message-ID: <20200925150605.GA2510@yoga> (raw)
In-Reply-To: <20200921082440.2591617-1-liushixin2@huawei.com>
On Mon 21 Sep 03:24 CDT 2020, Liu Shixin wrote:
> Simplify the return expression.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>
> ---
> drivers/media/platform/qcom/venus/hfi_venus.c | 28 +++----------------
> 1 file changed, 4 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/venus/hfi_venus.c b/drivers/media/platform/qcom/venus/hfi_venus.c
> index 4be4a75ddcb6..05ddb68023b8 100644
> --- a/drivers/media/platform/qcom/venus/hfi_venus.c
> +++ b/drivers/media/platform/qcom/venus/hfi_venus.c
> @@ -772,34 +772,24 @@ static int venus_sys_set_debug(struct venus_hfi_device *hdev, u32 debug)
> {
> struct hfi_sys_set_property_pkt *pkt;
> u8 packet[IFACEQ_VAR_SMALL_PKT_SIZE];
> - int ret;
>
> pkt = (struct hfi_sys_set_property_pkt *)packet;
>
> pkt_sys_debug_config(pkt, HFI_DEBUG_MODE_QUEUE, debug);
>
> - ret = venus_iface_cmdq_write(hdev, pkt);
> - if (ret)
> - return ret;
> -
> - return 0;
> + return venus_iface_cmdq_write(hdev, pkt);
> }
>
> static int venus_sys_set_coverage(struct venus_hfi_device *hdev, u32 mode)
> {
> struct hfi_sys_set_property_pkt *pkt;
> u8 packet[IFACEQ_VAR_SMALL_PKT_SIZE];
> - int ret;
>
> pkt = (struct hfi_sys_set_property_pkt *)packet;
>
> pkt_sys_coverage_config(pkt, mode);
>
> - ret = venus_iface_cmdq_write(hdev, pkt);
> - if (ret)
> - return ret;
> -
> - return 0;
> + return venus_iface_cmdq_write(hdev, pkt);
> }
>
> static int venus_sys_set_idle_message(struct venus_hfi_device *hdev,
> @@ -807,7 +797,6 @@ static int venus_sys_set_idle_message(struct venus_hfi_device *hdev,
> {
> struct hfi_sys_set_property_pkt *pkt;
> u8 packet[IFACEQ_VAR_SMALL_PKT_SIZE];
> - int ret;
>
> if (!enable)
> return 0;
> @@ -816,11 +805,7 @@ static int venus_sys_set_idle_message(struct venus_hfi_device *hdev,
>
> pkt_sys_idle_indicator(pkt, enable);
>
> - ret = venus_iface_cmdq_write(hdev, pkt);
> - if (ret)
> - return ret;
> -
> - return 0;
> + return venus_iface_cmdq_write(hdev, pkt);
> }
>
> static int venus_sys_set_power_control(struct venus_hfi_device *hdev,
> @@ -828,17 +813,12 @@ static int venus_sys_set_power_control(struct venus_hfi_device *hdev,
> {
> struct hfi_sys_set_property_pkt *pkt;
> u8 packet[IFACEQ_VAR_SMALL_PKT_SIZE];
> - int ret;
>
> pkt = (struct hfi_sys_set_property_pkt *)packet;
>
> pkt_sys_power_control(pkt, enable);
>
> - ret = venus_iface_cmdq_write(hdev, pkt);
> - if (ret)
> - return ret;
> -
> - return 0;
> + return venus_iface_cmdq_write(hdev, pkt);
> }
>
> static int venus_get_queue_size(struct venus_hfi_device *hdev,
> --
> 2.25.1
>
prev parent reply other threads:[~2020-09-25 15:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 8:24 [PATCH -next] media: venus: simplify the return expression of venus_sys_set_* function Liu Shixin
2020-09-25 15:06 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925150605.GA2510@yoga \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=liushixin2@huawei.com \
--cc=mchehab@kernel.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox