public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>,
	Joel Fernandes <joel@joelfernandes.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Namhyung Kim <namhyung@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux- stable <stable@vger.kernel.org>,
	Sasha Levin <sashal@kernel.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	LTP List <ltp@lists.linux.it>,
	lkft-triage@lists.linaro.org
Subject: Re: [stable 4.19] [PANIC]: tracing: Centralize preemptirq tracepoints and unify their usage
Date: Fri, 25 Sep 2020 17:12:45 +0200	[thread overview]
Message-ID: <20200925151245.GA3180934@kroah.com> (raw)
In-Reply-To: <20200925110706.6654954b@oasis.local.home>

On Fri, Sep 25, 2020 at 11:07:06AM -0400, Steven Rostedt wrote:
> On Fri, 25 Sep 2020 10:59:14 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> > On Fri, 25 Sep 2020 10:54:58 -0400
> > Steven Rostedt <rostedt@goodmis.org> wrote:
> > 
> > 
> > > The crash looks like its cr3 related, which I believe Peter Zijlstra  
> > 
> > s/cr3/cr2/
> > 
> 
> Specifically, commits:
> 
> a0d14b8909de55139b8702fe0c7e80b69763dcfb ("x86/mm, tracing: Fix CR2 corruption")
> 6879298bd0673840cadd1fb36d7225485504ceb4 ("x86/entry/64: Prevent clobbering of saved CR2 value")
> b8f70953c1251d8b16276995816a95639f598e70 ("x86/entry/32: Pass cr2 to do_async_page_fault()")
> 
> (which are in 5.4 but not 4.19)
> 
> But again, is this too intrusive. There was a workaround that was
> original proposed, but Peter didn't want any more band-aids, and did
> the restructuring, but as you can see from the two other patches, it
> makes it a bit more high risk.

If those are known to work, why can't I take them as-is?

thanks,

greg k-h

  reply	other threads:[~2020-09-25 15:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-23  2:38 [lkp-robot] [tracing] c3bc8fd637: WARNING:at_kernel/rcu/tree.c:#rcu_irq_enter kernel test robot
2018-08-28 19:53 ` Joel Fernandes
2020-09-25  4:43   ` [stable 4.19] [PANIC]: tracing: Centralize preemptirq tracepoints and unify their usage Naresh Kamboju
2020-09-25  5:15     ` Greg Kroah-Hartman
2020-09-25  7:25       ` Naresh Kamboju
2020-09-25 14:54         ` Steven Rostedt
2020-09-25 14:59           ` Steven Rostedt
2020-09-25 15:07             ` Steven Rostedt
2020-09-25 15:12               ` Greg Kroah-Hartman [this message]
2020-09-25 15:30                 ` Steven Rostedt
2020-10-05 13:18                   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200925151245.GA3180934@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=joel@joelfernandes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkft-triage@lists.linaro.org \
    --cc=ltp@lists.linux.it \
    --cc=mhiramat@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=naresh.kamboju@linaro.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox