From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF5C0C4727D for ; Fri, 25 Sep 2020 15:12:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 672FC208B6 for ; Fri, 25 Sep 2020 15:12:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601046753; bh=AC+wa/fdvJWpdBXneQDQ+O1+KwHjfEGWjJz6XcjZn8k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=YEVI7T0FOW3lcWoIeKiiFdhWlo7coudzbAWVCsZgWemcVmnYtS9T3EzLN5VpFk2cq TAxxpLhYOP6PX192C6MfZHHOl2vUHNrtXAgUO/145pAwgAP7Ce5tn8Pc3EdUsfLJpw nKDgXSGs5C+GiyD+1xQmbHkDbCTraN/i5T/KICqw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729230AbgIYPMc (ORCPT ); Fri, 25 Sep 2020 11:12:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:48790 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728333AbgIYPMb (ORCPT ); Fri, 25 Sep 2020 11:12:31 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E025820878; Fri, 25 Sep 2020 15:12:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601046751; bh=AC+wa/fdvJWpdBXneQDQ+O1+KwHjfEGWjJz6XcjZn8k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=irEjCYSXRmp24bxania70XdYpwVoWuYllOsHdYjsw81ZxceabVvzFaP35Ft2OBMzh fojlJGnsMuWl+QUpRNTC1ioCNHM6vN6/wklmpzNHzADeQZI5PzuRjxao03cYlNcfl0 MFvCIlLARVYCY9XsrmVOjCFA2D+xASOLy3zgVLUY= Date: Fri, 25 Sep 2020 17:12:45 +0200 From: Greg Kroah-Hartman To: Steven Rostedt Cc: Naresh Kamboju , Joel Fernandes , Peter Zijlstra , Namhyung Kim , LKML , linux- stable , Sasha Levin , Masami Hiramatsu , LTP List , lkft-triage@lists.linaro.org Subject: Re: [stable 4.19] [PANIC]: tracing: Centralize preemptirq tracepoints and unify their usage Message-ID: <20200925151245.GA3180934@kroah.com> References: <20180823023839.GA13343@shao2-debian> <20180828195347.GA228832@joelaf.mtv.corp.google.com> <20200925051518.GA605188@kroah.com> <20200925105458.567d0bf4@oasis.local.home> <20200925105914.7de88d27@oasis.local.home> <20200925110706.6654954b@oasis.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200925110706.6654954b@oasis.local.home> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 25, 2020 at 11:07:06AM -0400, Steven Rostedt wrote: > On Fri, 25 Sep 2020 10:59:14 -0400 > Steven Rostedt wrote: > > > On Fri, 25 Sep 2020 10:54:58 -0400 > > Steven Rostedt wrote: > > > > > > > The crash looks like its cr3 related, which I believe Peter Zijlstra > > > > s/cr3/cr2/ > > > > Specifically, commits: > > a0d14b8909de55139b8702fe0c7e80b69763dcfb ("x86/mm, tracing: Fix CR2 corruption") > 6879298bd0673840cadd1fb36d7225485504ceb4 ("x86/entry/64: Prevent clobbering of saved CR2 value") > b8f70953c1251d8b16276995816a95639f598e70 ("x86/entry/32: Pass cr2 to do_async_page_fault()") > > (which are in 5.4 but not 4.19) > > But again, is this too intrusive. There was a workaround that was > original proposed, but Peter didn't want any more band-aids, and did > the restructuring, but as you can see from the two other patches, it > makes it a bit more high risk. If those are known to work, why can't I take them as-is? thanks, greg k-h