From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Qinglang Miao <miaoqinglang@huawei.com>
Cc: Stanimir Varbanov <stanimir.varbanov@linaro.org>,
Andy Gross <agross@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] media: venus: simplify the return expression of session_process_buf()
Date: Fri, 25 Sep 2020 10:13:28 -0500 [thread overview]
Message-ID: <20200925151328.GC2510@yoga> (raw)
In-Reply-To: <20200921131038.92204-1-miaoqinglang@huawei.com>
On Mon 21 Sep 08:10 CDT 2020, Qinglang Miao wrote:
> Simplify the return expression.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
> ---
> drivers/media/platform/qcom/venus/helpers.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c
> index 50439eb1f..fb3fd3640 100644
> --- a/drivers/media/platform/qcom/venus/helpers.c
> +++ b/drivers/media/platform/qcom/venus/helpers.c
> @@ -439,7 +439,6 @@ session_process_buf(struct venus_inst *inst, struct vb2_v4l2_buffer *vbuf)
> struct vb2_buffer *vb = &vbuf->vb2_buf;
> unsigned int type = vb->type;
> struct hfi_frame_data fdata;
> - int ret;
>
> memset(&fdata, 0, sizeof(fdata));
> fdata.alloc_len = buf->size;
> @@ -470,11 +469,7 @@ session_process_buf(struct venus_inst *inst, struct vb2_v4l2_buffer *vbuf)
> fdata.offset = 0;
> }
>
> - ret = hfi_session_process_buf(inst, &fdata);
> - if (ret)
> - return ret;
> -
> - return 0;
> + return hfi_session_process_buf(inst, &fdata);
> }
>
> static bool is_dynamic_bufmode(struct venus_inst *inst)
> --
> 2.23.0
>
prev parent reply other threads:[~2020-09-25 15:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 13:10 [PATCH -next] media: venus: simplify the return expression of session_process_buf() Qinglang Miao
2020-09-25 15:13 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925151328.GC2510@yoga \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=miaoqinglang@huawei.com \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox